From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59FA8A04DE for ; Tue, 20 Oct 2020 11:55:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 31463CA06; Tue, 20 Oct 2020 11:55:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 31FF0BE0B for ; Tue, 20 Oct 2020 11:55:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603187723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iVRwlHp70XC2jPkd6YuVgOckT1DULndxqZl7g5Q9xy4=; b=HP/TCggIo+6BrzQyzxwTfaM9ep2qsUaQUXznDDR0DpIC7prho+HAlOitIt8qp08Bihiekr TnQG7G3yZ5RPpm6lplx8nqDUp+l9hjBA05inv8fVbFMINSTCpqJiLtCTDfzwKTxvsqS/gj cFIFZQ+QECm3Zs4TThIEN6/Q+xgv710= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-Sns58TOuMQKfHjMsAUx9Wg-1; Tue, 20 Oct 2020 05:55:19 -0400 X-MC-Unique: Sns58TOuMQKfHjMsAUx9Wg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24BBF64094; Tue, 20 Oct 2020 09:55:18 +0000 (UTC) Received: from [10.36.110.40] (unknown [10.36.110.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 27C755B4AD; Tue, 20 Oct 2020 09:55:11 +0000 (UTC) To: Kevin Traynor , Adrian Moreno , dev@dpdk.org Cc: yinan.wang@intel.com, patrick.fu@intel.com, stable@dpdk.org, Chenbo Xia , Zhihong Wang References: <20201020071628.323641-1-amorenoz@redhat.com> <525cba16-8f46-fc7e-47ec-1f0ec45c00e2@redhat.com> <7aa64791-d71f-c195-f2d6-6262afc29fe7@redhat.com> From: Maxime Coquelin Message-ID: <34c221fb-f44b-251b-6183-c6606b0b29b6@redhat.com> Date: Tue, 20 Oct 2020 11:55:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <7aa64791-d71f-c195-f2d6-6262afc29fe7@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 10/20/20 11:38 AM, Kevin Traynor wrote: > On 20/10/2020 10:11, Maxime Coquelin wrote: >> >> >> On 10/20/20 11:01 AM, Kevin Traynor wrote: >>> On 20/10/2020 08:16, Adrian Moreno wrote: >>>> If stat fails it means the backend must be vhost-user in server mode >>>> >>>> Bugzilla ID: 559 >>>> Fixes: f908b22ea47a ("net/virtio: move backend type selection to ethdev") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Adrian Moreno >>>> --- >>>> drivers/net/virtio/virtio_user_ethdev.c | 5 +++-- >>>> 1 file changed, 3 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c >>>> index 042665bc0..ce74d08ab 100644 >>>> --- a/drivers/net/virtio/virtio_user_ethdev.c >>>> +++ b/drivers/net/virtio/virtio_user_ethdev.c >>>> @@ -560,9 +560,10 @@ virtio_user_backend_type(const char *path) >>>> struct stat sb; >>>> >>>> if (stat(path, &sb) == -1) { >>>> - PMD_INIT_LOG(ERR, "Stat fails: %s (%s)\n", path, >>>> + PMD_INIT_LOG(INFO, "Stat fails: %s (%s)\n", path, >>>> strerror(errno)); >>> >>> It may be accurate, but a 'fail' in the logs can be confusing for users >>> when it is an INFO log and normal operation. Suggest to reword to >>> something softer like 'Unable to stat' or 'Not able to get file status' >> >> >> We may want to: >> - only return VIRTIO_USER_BACKEND_VHOST_USER if -ENOENT, and log that >> we assume this is Vhost-user backend in server mode at INFO level. > > It will mean that sometimes the backend type is logged and sometimes > not, but maybe you make a distinction because there is an assumption > being made in this case? I agree it would make sense to log at INFO level for all backend types. >> - return VIRTIO_USER_BACKEND_UNKNOWN otherwise and print an error >> message with the strerror(errno). >> > > yes, it seems better like that. > >> What do you think? >> >>>> - return VIRTIO_USER_BACKEND_UNKNOWN; >>>> + /* Must be vhost-user in server mode */ >>>> + return VIRTIO_USER_BACKEND_VHOST_USER; >>>> } >>>> >>>> if (S_ISSOCK(sb.st_mode)) { >>>> >>> >