patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/virtio: fix uninitialized duplex mode
@ 2021-07-27  5:14 Chenbo Xia
  2021-07-27 13:35 ` Maxime Coquelin
  2021-07-28  6:52 ` [dpdk-stable] [dpdk-dev] " Xia, Chenbo
  0 siblings, 2 replies; 3+ messages in thread
From: Chenbo Xia @ 2021-07-27  5:14 UTC (permalink / raw)
  To: dev; +Cc: maxime.coquelin, stable

When virtio front-end initializes, the duplex mode should be set
unknown before reading any duplex mode information from configuration
space. This patch fixes the issue that duplex mode is by default set
to zero, which equals ETH_LINK_HALF_DUPLEX. This will lead to duplex
mode being half duplex when fron-end does not have the feature
named VIRTIO_NET_F_SPEED_DUPLEX.

Fixes: 1357b4b36246 ("net/virtio: support Virtio link speed feature")
Cc: stable@dpdk.org

Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
---
 drivers/net/virtio/virtio_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 72d3dda71f..9061db4e41 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1901,6 +1901,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
 	if (ret < 0)
 		return ret;
 	hw->speed = speed;
+	hw->duplex = DUPLEX_UNKNOWN;
 
 	/* Allocate memory for storing MAC addresses */
 	eth_dev->data->mac_addrs = rte_zmalloc("virtio",
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/virtio: fix uninitialized duplex mode
  2021-07-27  5:14 [dpdk-stable] [PATCH] net/virtio: fix uninitialized duplex mode Chenbo Xia
@ 2021-07-27 13:35 ` Maxime Coquelin
  2021-07-28  6:52 ` [dpdk-stable] [dpdk-dev] " Xia, Chenbo
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2021-07-27 13:35 UTC (permalink / raw)
  To: Chenbo Xia, dev; +Cc: stable



On 7/27/21 7:14 AM, Chenbo Xia wrote:
> When virtio front-end initializes, the duplex mode should be set
> unknown before reading any duplex mode information from configuration
> space. This patch fixes the issue that duplex mode is by default set
> to zero, which equals ETH_LINK_HALF_DUPLEX. This will lead to duplex
> mode being half duplex when fron-end does not have the feature
> named VIRTIO_NET_F_SPEED_DUPLEX.
> 
> Fixes: 1357b4b36246 ("net/virtio: support Virtio link speed feature")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 72d3dda71f..9061db4e41 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1901,6 +1901,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
>  	if (ret < 0)
>  		return ret;
>  	hw->speed = speed;
> +	hw->duplex = DUPLEX_UNKNOWN;
>  
>  	/* Allocate memory for storing MAC addresses */
>  	eth_dev->data->mac_addrs = rte_zmalloc("virtio",
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/virtio: fix uninitialized duplex mode
  2021-07-27  5:14 [dpdk-stable] [PATCH] net/virtio: fix uninitialized duplex mode Chenbo Xia
  2021-07-27 13:35 ` Maxime Coquelin
@ 2021-07-28  6:52 ` Xia, Chenbo
  1 sibling, 0 replies; 3+ messages in thread
From: Xia, Chenbo @ 2021-07-28  6:52 UTC (permalink / raw)
  To: Xia, Chenbo, dev; +Cc: maxime.coquelin, stable

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Chenbo Xia
> Sent: Tuesday, July 27, 2021 1:15 PM
> To: dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/virtio: fix uninitialized duplex mode
> 
> When virtio front-end initializes, the duplex mode should be set
> unknown before reading any duplex mode information from configuration
> space. This patch fixes the issue that duplex mode is by default set
> to zero, which equals ETH_LINK_HALF_DUPLEX. This will lead to duplex
> mode being half duplex when fron-end does not have the feature
> named VIRTIO_NET_F_SPEED_DUPLEX.
> 
> Fixes: 1357b4b36246 ("net/virtio: support Virtio link speed feature")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c
> b/drivers/net/virtio/virtio_ethdev.c
> index 72d3dda71f..9061db4e41 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1901,6 +1901,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
>  	if (ret < 0)
>  		return ret;
>  	hw->speed = speed;
> +	hw->duplex = DUPLEX_UNKNOWN;
> 
>  	/* Allocate memory for storing MAC addresses */
>  	eth_dev->data->mac_addrs = rte_zmalloc("virtio",
> --
> 2.17.1

Applied to next-virtio/main. Thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-28  6:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27  5:14 [dpdk-stable] [PATCH] net/virtio: fix uninitialized duplex mode Chenbo Xia
2021-07-27 13:35 ` Maxime Coquelin
2021-07-28  6:52 ` [dpdk-stable] [dpdk-dev] " Xia, Chenbo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).