From: "Eelco Chaudron" <echaudro@redhat.com>
To: "David Marchand" <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org,
"Qiming Yang" <qiming.yang@intel.com>,
"Wenzhuo Lu" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-stable] [PATCH 2/2] net/ice: fix dropped packets statistics name
Date: Mon, 03 Jun 2019 10:52:47 +0200 [thread overview]
Message-ID: <356C41E4-5A51-4013-AB44-F48DC74740F7@redhat.com> (raw)
In-Reply-To: <1559550688-9290-2-git-send-email-david.marchand@redhat.com>
Looks good to me…
Acked-by: Eelco Chaudron <echaudro@redhat.com>
On 3 Jun 2019, at 10:31, David Marchand wrote:
> Copy/paste from i40e, let's align with the fix on i40e.
>
> Fixes: a37bde56314d ("net/ice: support statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/ice/ice_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index bdbceb4..6cd1c74 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -153,13 +153,13 @@ struct ice_xstats_name_off {
> {"rx_unicast_packets", offsetof(struct ice_eth_stats, rx_unicast)},
> {"rx_multicast_packets", offsetof(struct ice_eth_stats, rx_multicast)},
> {"rx_broadcast_packets", offsetof(struct ice_eth_stats, rx_broadcast)},
> - {"rx_dropped", offsetof(struct ice_eth_stats, rx_discards)},
> + {"rx_dropped_packets", offsetof(struct ice_eth_stats, rx_discards)},
> {"rx_unknown_protocol_packets", offsetof(struct ice_eth_stats,
> rx_unknown_protocol)},
> {"tx_unicast_packets", offsetof(struct ice_eth_stats, tx_unicast)},
> {"tx_multicast_packets", offsetof(struct ice_eth_stats, tx_multicast)},
> {"tx_broadcast_packets", offsetof(struct ice_eth_stats, tx_broadcast)},
> - {"tx_dropped", offsetof(struct ice_eth_stats, tx_discards)},
> + {"tx_dropped_packets", offsetof(struct ice_eth_stats, tx_discards)},
> };
>
> #define ICE_NB_ETH_XSTATS (sizeof(ice_stats_strings) / \
> --
> 1.8.3.1
next prev parent reply other threads:[~2019-06-03 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 8:31 [dpdk-stable] [PATCH 1/2] net/i40e: " David Marchand
2019-06-03 8:31 ` [dpdk-stable] [PATCH 2/2] net/ice: " David Marchand
2019-06-03 8:52 ` Eelco Chaudron [this message]
2019-06-18 14:02 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2019-06-03 8:52 ` [dpdk-stable] [PATCH 1/2] net/i40e: " Eelco Chaudron
2019-06-11 11:15 ` David Marchand
2019-06-12 1:34 ` [dpdk-stable] [dpdk-dev] " Xing, Beilei
2019-06-18 13:59 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=356C41E4-5A51-4013-AB44-F48DC74740F7@redhat.com \
--to=echaudro@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).