From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E52CCA04B6 for ; Tue, 13 Oct 2020 11:42:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3F641DA49; Tue, 13 Oct 2020 11:42:43 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 375C31DA31; Tue, 13 Oct 2020 11:42:39 +0200 (CEST) IronPort-SDR: fT+VCzLJBeXaemyz+KqQC/8WZqclRcWrzpUp+AXs0pXeyWs9cPduVx4RJSZ5+WGpdTWK4DALcr MP5qglhDZw7Q== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="153711930" X-IronPort-AV: E=Sophos;i="5.77,369,1596524400"; d="scan'208";a="153711930" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 02:42:38 -0700 IronPort-SDR: SzBMp04hOhwnmNQDH19F2cHMzabMUeJSQiqwxpgYtdcjJcraRe2nbPecsxDLF7+3BZGuqIrRXa mBBtCxwgn5Qg== X-IronPort-AV: E=Sophos;i="5.77,369,1596524400"; d="scan'208";a="530329311" Received: from sritenbe-mobl1.ger.corp.intel.com (HELO [10.251.176.132]) ([10.251.176.132]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 02:42:35 -0700 To: Nick Connolly , David Marchand , Olivier Matz , Didier Pallard , Nicolas Dichtel Cc: dev@dpdk.org, stable@dpdk.org References: <20201012192256.3651-1-nick.connolly@mayadata.io> From: "Burakov, Anatoly" Message-ID: <357aeeec-f5f6-4ae4-7a62-47e89a9450ee@intel.com> Date: Tue, 13 Oct 2020 10:42:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201012192256.3651-1-nick.connolly@mayadata.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v2] mem: fix allocation failure on non-NUMA kernel X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 12-Oct-20 8:22 PM, Nick Connolly wrote: > Running dpdk-helloworld on Linux with lib numa present, > but no kernel support for NUMA (CONFIG_NUMA=n) causes > ret_service_init() to fail with EAL: error allocating > rte services array. > > alloc_seg() calls get_mempolicy to verify that the allocation > has happened on the correct socket, but receives ENOSYS from > the kernel and fails the allocation. > > The allocated socket should only be verified if check_numa() is true. > > Fixes: 2a96c88be83e ("mem: ease init in a docker container") > Cc: nicolas.dichtel@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Nick Connolly > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly