From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
[64.147.123.25]) by dpdk.org (Postfix) with ESMTP id BEF1A2B9A;
Mon, 17 Sep 2018 10:42:28 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.west.internal (Postfix) with ESMTP id 4D6CB3EE;
Mon, 17 Sep 2018 04:42:27 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Mon, 17 Sep 2018 04:42:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=iMAVUvwMbNi+/s8lMPPshNT/ss
w9Pgye109lGVEXN1g=; b=B2AhYmbmie6B7+EA9rJg+NCzZhBnkN+hgFZR43RlLo
OBx3f1WWqGg7Te93KpohxJEjKzPul3VSfZuLQbJM4dqfQgAfiNCSpqTboDugH2Eu
DhfXre5YANjxhbwZJ+/zfbYednWtgpA5etIKjVVxI7WB1PeHW0Q5ZQsv91xQxLCu
o=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=iMAVUv
wMbNi+/s8lMPPshNT/ssw9Pgye109lGVEXN1g=; b=DlkAr2gqZIyQ6XM/H2AxQL
nDC5bg8GS3wu+FFDuSkqKGqrAsQB4J120pdtyHonY/Pb5DdkU17sceLFKDQlQRD5
cuT2YBYW93aCHjwUvHHTjJiswXCId3ZphNPdEOMAaAKB+LN2kO9HW++TbyowztNB
5CC1Bwk85WOKl9u8SEzKWnq4eyezqpKl5KEoCepwHCjBxDhQbPrhrDaYcmGyv6gd
znEBJCheo/xH/1dW/X54xGXvJJFo0oBoVlulg5wHyaDSob1UjXbdMqjbF8jHebMq
hJVqTB7fVc+PWSs6A0F2ImnDWVrwjEFvP/5nkmeZ4DFac3EAwMh6eXNCN2M81dgg
==
X-ME-Proxy: <xmx:8mifW7vQ25mq74oUktYaK-_3Kmp66lLRGHu6chxQF90go4ONdaBNWw>
<xmx:8mifW9JPMyUB1vc22xpwjJ1KQpgl5hV-MOD0T6JbCvlGIbcPd5kzTg>
<xmx:8mifW8983OmCZsvYXDrNGFuhiZJr28wLsC7MbZlu7COkMzeQJaCB0g>
<xmx:8mifW-x9JI6C95QAaCTqBjbhwQqY2DE1LYhOD3eJmHj5w02n_jhPSg>
<xmx:8mifWx4BFoCLPhzbqp9J5P4v_ydOP7HmvYchtJSgFT90MN7iV_H9xA>
<xmx:8mifW350s5w6sqBHU4cEOAOhA-ErzKdWz9moa2fZMjzgHLR7beGyrg>
X-ME-Sender: <xms:8mifW72s_xB-xjEi_luk6HnQCVF7c636W4OKLl25v1yGoy1bLawotw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id C1F6B102DD;
Mon, 17 Sep 2018 04:42:25 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, bluca@debian.org, stable@dpdk.org
Date: Mon, 17 Sep 2018 10:42:24 +0200
Message-ID: <3722786.uIPfu17pdJ@xps>
In-Reply-To: <20180917081800.8912-1-bruce.richardson@intel.com>
References: <20180830170701.21443-1-bruce.richardson@intel.com>
<20180917081800.8912-1-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] compat: fix symbol version
support with meson
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 08:42:29 -0000
17/09/2018 10:18, Bruce Richardson:
> For meson builds, the define to enable the symbol version
> macros in rte_compat.h was missing. This led to symbols being
> omitted from shared objects. For example, checking rte_distributor.so
> with objdump and comparing make and meson built versions:
>
> $ objdump -T make-build/lib/librte_distributor.so | grep _flush
> 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush
> 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush
> $ objdump -T meson-build/lib/librte_distributor.so | grep _flush
> 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush
>
> Adding in the missing define fixes this.
>
> Fixes: 5b9656b157d3 ("lib: build with meson")
>
> CC: stable@dpdk.org
> Reported-by: Luca Boccassi <bluca@debian.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Tested-by: Luca Boccassi <bluca@debian.org>
Applied, thanks