From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 63509A0096 for ; Mon, 3 Jun 2019 10:52:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3FA8C1B959; Mon, 3 Jun 2019 10:52:48 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 418711B944; Mon, 3 Jun 2019 10:52:45 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9EA4D5946B; Mon, 3 Jun 2019 08:52:44 +0000 (UTC) Received: from [10.36.116.210] (ovpn-116-210.ams2.redhat.com [10.36.116.210]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 971F019C69; Mon, 3 Jun 2019 08:52:41 +0000 (UTC) From: "Eelco Chaudron" To: "David Marchand" Cc: dev@dpdk.org, stable@dpdk.org, "Beilei Xing" , "Qi Zhang" Date: Mon, 03 Jun 2019 10:52:39 +0200 Message-ID: <37575ABF-0B4F-4677-AD63-D79A6DF176BE@redhat.com> In-Reply-To: <1559550688-9290-1-git-send-email-david.marchand@redhat.com> References: <1559550688-9290-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 03 Jun 2019 08:52:44 +0000 (UTC) Subject: Re: [dpdk-stable] [PATCH 1/2] net/i40e: fix dropped packets statistics name X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Looks good to me… Acked-by: Eelco Chaudron On 3 Jun 2019, at 10:31, David Marchand wrote: > i40e and i40evf currently use two different names for the statistic on > dropped packets on the rx and tx sides. > Let's prefer i40evf so that all statistics are suffixed with _packets. > > This also avoids a statistic name conflict in OVS. > > Fixes: f4a91c38b4ad ("i40e: add extended stats") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/i40e/i40e_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c > b/drivers/net/i40e/i40e_ethdev.c > index 7fa9e1b..2384d4d 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -526,13 +526,13 @@ struct rte_i40e_xstats_name_off { > {"rx_unicast_packets", offsetof(struct i40e_eth_stats, rx_unicast)}, > {"rx_multicast_packets", offsetof(struct i40e_eth_stats, > rx_multicast)}, > {"rx_broadcast_packets", offsetof(struct i40e_eth_stats, > rx_broadcast)}, > - {"rx_dropped", offsetof(struct i40e_eth_stats, rx_discards)}, > + {"rx_dropped_packets", offsetof(struct i40e_eth_stats, > rx_discards)}, > {"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats, > rx_unknown_protocol)}, > {"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)}, > {"tx_multicast_packets", offsetof(struct i40e_eth_stats, > tx_multicast)}, > {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, > tx_broadcast)}, > - {"tx_dropped", offsetof(struct i40e_eth_stats, tx_discards)}, > + {"tx_dropped_packets", offsetof(struct i40e_eth_stats, > tx_discards)}, > }; > > #define I40E_NB_ETH_XSTATS (sizeof(rte_i40e_stats_strings) / \ > -- > 1.8.3.1