From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13971A0A02 for ; Wed, 5 May 2021 12:13:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00D65410E9; Wed, 5 May 2021 12:13:08 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 02F334003C; Wed, 5 May 2021 12:13:04 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 8387F17D0; Wed, 5 May 2021 06:13:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 05 May 2021 06:13:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= noit/iZ5ewQopatTAdggafs5xThRb3BNFRHH+JGMsYk=; b=SQCA8HY5EmPE2eI6 +reJPW7kObwqOWK8NKBmnt+n9WSaoIuRaHILGIzLYv4AttjnCFBIbN/IvPE5MNnB 6XJ6y4ZO6icbjVBgaXawyJg6yN4HY/++n195i8ALG+JkZM4F0spj+AZmU5aVluBI 79Al1C2GdrMhH3YFAW9vDl8Tn6clVwpGCiLbT2isEE5ebBl/521g+mIQBC563AnA N+Nqt+aoq5eKkG01kwY6VH+OxcBC8M24yE6EZlJouiGCCNYniewz/aSq/yAFmo9I dRcFs136zTtgTSN18dI6VJLY/Ho+rgHbOzpe9vqYuyR1i6dz7qT5EWY8z3uAQUav uR6vtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=noit/iZ5ewQopatTAdggafs5xThRb3BNFRHH+JGMs Yk=; b=ZX16x7rga04Qc0j3oE3OME4ApyhqmEzbt5UxOmpOK9y3QoQ3husXhNe7K +Dt+KzvK5RqD2cIiw+KPHnn8qElKwz6N8lv2jfO/YEuVrSbR4vIZIU5gZ/NPvxLY EI2706P/hlD2XA1Mq2oN8syC22PICtMwmwMILsvVp2qFdgUR9r59I1yuWfiFn9/d HvPEx5b9gqcdFKGPk6AsxIk2RasFt6RqPGRgu2u1TFTWZSOv3sfLNjmXi9UgqN/v L9GM8OfIiAMtJRBxjwootLDyhaO2+Ko7XqeW5CRAk6iqfOdoUSidYl7WiuA7eLzM a/5h5EUlInSzHLYzPZNVDFPjWt45A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefkedgvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 May 2021 06:13:02 -0400 (EDT) From: Thomas Monjalon To: Konstantin Ananyev Cc: dev@dpdk.org, stable@dpdk.org Date: Wed, 05 May 2021 12:13:00 +0200 Message-ID: <37680552.IiN9YLNMxG@thomas> In-Reply-To: <20210426133519.4777-1-konstantin.ananyev@intel.com> References: <20210423135451.11035-1-konstantin.ananyev@intel.com> <20210426133519.4777-1-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] acl: fix build with gcc 11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 26/04/2021 15:35, Konstantin Ananyev: > gcc 11 with '-O2' complains about some variables being used without > being initialized: >=20 > In file included from ../lib/librte_acl/acl_run_avx512x8.h:201, > from ../lib/librte_acl/acl_run_avx512.c:110: > In function =E2=80=98start_flow_avx512x8=E2=80=99, > inlined from =E2=80=98search_trie_avx512x8.constprop=E2=80=99 at ../l= ib/librte_acl/acl_run_avx512_common.h:317:2: > ../lib/librte_acl/acl_run_avx512_common.h:210:13: warning: =E2=80=98pdata= =E2=80=99 is used uninitialized [-Wuninitialized] > In file included from ../lib/librte_acl/acl_run_avx512x8.h:201, > from ../lib/librte_acl/acl_run_avx512.c:110: > ../lib/librte_acl/acl_run_avx512_common.h: In function =E2=80=98search_tr= ie_avx512x8.constprop=E2=80=99: > ../lib/librte_acl/acl_run_avx512_common.h:314:32: note: =E2=80=98pdata=E2= =80=99 declared here > In file included from ../lib/librte_acl/acl_run_avx512x8.h:201, > from ../lib/librte_acl/acl_run_avx512.c:110: > .... >=20 > Indeed, these variables are not explicitly initialized, > but this is done intentionally. > We rely on constant mask value that we pass to start_flow*() functions > as a parameter to mask out uninitialized values. > Note that '-O3' doesn't produce this warning. > Anyway, to support clean build with gcc-11 this patch adds > explicit initialization for these variables. > I checked the output binary: with '-O3' both clang and gcc 10/11 > generate no extra code for it. > Also performance test didn't reveal any regressions. >=20 > Bugzilla ID: 673 > Fixes: b64c2295f7fc ("acl: add 256-bit AVX512 classify method") > Fixes: 45da22e42ec3 ("acl: add 512-bit AVX512 classify method") > Cc: stable@dpdk.org >=20 > Reported-by: Ali Alnubani > Signed-off-by: Konstantin Ananyev Applied, thanks