patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
	Thierry Herbelot <thierry.herbelot@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
Date: Mon, 21 Jun 2021 18:14:42 +0200
Message-ID: <3815134.CEuO83SSsj@thomas> (raw)
In-Reply-To: <786a1730-37eb-8f22-7812-74a8a7096dd9@6wind.com>

21/06/2021 17:54, Thierry Herbelot:
> On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> >>>>> Check Bucket key for all possible indices.
> >>>>>
> >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> >>>>> Cc: stable@dpdk.org
> >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>>>
> >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> >>> [...]
> >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> >>>>
> >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>>
> >>>> Thierry, thanks again, you could have actually added my ack from V1 :)
> >>>
> >>> The root cause looks to be a typo indeed,
> >>> but the impact or the scope of the issue
> >>> should stated in few words in the title please.
> >>> No need to send a v3, please suggest a title and I will apply.
> >>
> >> table: check a bucket is empty for all bucket keys
> >>
> >> 	Thierry
> >>
> > 
> > Hi Thierry,
> > 
> > I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?

No need to send a v3.
> 
> Hello Cristian
> 
> Sure !
> 
> What do you think of this title:
> 
> "table: check a bucket is empty for all bucket keys"

This title suggests it was not the intent before.
It should say that it fixes this check,
or better, name the area of the API which is fixed.



  reply	other threads:[~2021-06-21 16:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24  8:53 [dpdk-stable] [PATCH] rte_swx: " Thierry Herbelot
2021-05-24 11:25 ` Dumitrescu, Cristian
2021-05-24 11:28 ` [dpdk-stable] [PATCH v2] table: " Thierry Herbelot
2021-05-24 11:30   ` Dumitrescu, Cristian
2021-06-17  7:01     ` Thomas Monjalon
2021-06-17  7:11       ` Thierry Herbelot
2021-06-21 15:44         ` Dumitrescu, Cristian
2021-06-21 15:54           ` Thierry Herbelot
2021-06-21 16:14             ` Thomas Monjalon [this message]
2021-06-21 16:56               ` Dumitrescu, Cristian
2021-06-29 11:35                 ` Dumitrescu, Cristian
2021-06-29 13:41                   ` Thomas Monjalon
2021-06-29 13:51                     ` Dumitrescu, Cristian
2021-07-03  0:07                       ` Dumitrescu, Cristian
2021-06-21 17:23               ` Thierry Herbelot
2021-07-07 11:19   ` [dpdk-stable] [PATCH V3] table: fix bucket empty logic Thierry Herbelot
2021-07-07 11:23     ` Dumitrescu, Cristian
2021-07-09 20:43       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3815134.CEuO83SSsj@thomas \
    --to=thomas@monjalon.net \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thierry.herbelot@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git