* Re: [PATCH 1/1] vfio: Make buildable with MUSL runtime [not found] ` <9ebbc874-a6b0-b2f0-8e3b-e1f7d5bd0e8f@intel.com> @ 2023-05-23 10:33 ` Thomas Monjalon 2023-05-23 15:46 ` Philip Prindeville 0 siblings, 1 reply; 4+ messages in thread From: Thomas Monjalon @ 2023-05-23 10:33 UTC (permalink / raw) To: Philip Prindeville; +Cc: dev, Burakov, Anatoly, stable 22/05/2023 11:27, Burakov, Anatoly: > On 5/20/2023 7:07 PM, Philip Prindeville wrote: > > From: Philip Prindeville <philipp@redfish-solutions.com> > > > > pread64() and pwrite64() are declared in <unistd.h> in MUSL and > > other (i.e. not glibc) C runtimes. > > > > Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> It was "buildable" already, and I don't understand how. In any doubt, I've added Cc: stable@dpdk.org for backports. Applied, thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] vfio: Make buildable with MUSL runtime 2023-05-23 10:33 ` [PATCH 1/1] vfio: Make buildable with MUSL runtime Thomas Monjalon @ 2023-05-23 15:46 ` Philip Prindeville 2023-05-23 16:36 ` Thomas Monjalon 0 siblings, 1 reply; 4+ messages in thread From: Philip Prindeville @ 2023-05-23 15:46 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, Burakov, Anatoly, stable > On May 23, 2023, at 5:33 AM, Thomas Monjalon <thomas@monjalon.net> wrote: > > 22/05/2023 11:27, Burakov, Anatoly: >> On 5/20/2023 7:07 PM, Philip Prindeville wrote: >>> From: Philip Prindeville <philipp@redfish-solutions.com> >>> >>> pread64() and pwrite64() are declared in <unistd.h> in MUSL and >>> other (i.e. not glibc) C runtimes. >>> >>> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> >> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> > > It was "buildable" already, and I don't understand how. > In any doubt, I've added Cc: stable@dpdk.org for backports. > > Applied, thanks. > > Yeah, it builds with glibc just fine. MUSL is another story... ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] vfio: Make buildable with MUSL runtime 2023-05-23 15:46 ` Philip Prindeville @ 2023-05-23 16:36 ` Thomas Monjalon 2023-05-23 19:00 ` Philip Prindeville 0 siblings, 1 reply; 4+ messages in thread From: Thomas Monjalon @ 2023-05-23 16:36 UTC (permalink / raw) To: Philip Prindeville; +Cc: dev, Burakov, Anatoly, stable 23/05/2023 17:46, Philip Prindeville: > > > On May 23, 2023, at 5:33 AM, Thomas Monjalon <thomas@monjalon.net> wrote: > > > > 22/05/2023 11:27, Burakov, Anatoly: > >> On 5/20/2023 7:07 PM, Philip Prindeville wrote: > >>> From: Philip Prindeville <philipp@redfish-solutions.com> > >>> > >>> pread64() and pwrite64() are declared in <unistd.h> in MUSL and > >>> other (i.e. not glibc) C runtimes. > >>> > >>> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> > >> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> > > > > It was "buildable" already, and I don't understand how. > > In any doubt, I've added Cc: stable@dpdk.org for backports. > > > > Applied, thanks. > > Yeah, it builds with glibc just fine. MUSL is another story... It is also building on Alpine/musl. I would like to understand why. Do you have failure logs and versions? ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] vfio: Make buildable with MUSL runtime 2023-05-23 16:36 ` Thomas Monjalon @ 2023-05-23 19:00 ` Philip Prindeville 0 siblings, 0 replies; 4+ messages in thread From: Philip Prindeville @ 2023-05-23 19:00 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, Burakov, Anatoly, stable > On May 23, 2023, at 11:36 AM, Thomas Monjalon <thomas@monjalon.net> wrote: > > 23/05/2023 17:46, Philip Prindeville: >> >>> On May 23, 2023, at 5:33 AM, Thomas Monjalon <thomas@monjalon.net> wrote: >>> >>> 22/05/2023 11:27, Burakov, Anatoly: >>>> On 5/20/2023 7:07 PM, Philip Prindeville wrote: >>>>> From: Philip Prindeville <philipp@redfish-solutions.com> >>>>> >>>>> pread64() and pwrite64() are declared in <unistd.h> in MUSL and >>>>> other (i.e. not glibc) C runtimes. >>>>> >>>>> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com> >>>> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> >>> >>> It was "buildable" already, and I don't understand how. >>> In any doubt, I've added Cc: stable@dpdk.org for backports. >>> >>> Applied, thanks. >> >> Yeah, it builds with glibc just fine. MUSL is another story... > > It is also building on Alpine/musl. > I would like to understand why. > Do you have failure logs and versions? > Have a look at: https://github.com/k13132/openwrt-dpdk/pull/9#issuecomment-1556124647 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-23 19:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230520180730.5789-1-philipp@redfish-solutions.com>
[not found] ` <9ebbc874-a6b0-b2f0-8e3b-e1f7d5bd0e8f@intel.com>
2023-05-23 10:33 ` [PATCH 1/1] vfio: Make buildable with MUSL runtime Thomas Monjalon
2023-05-23 15:46 ` Philip Prindeville
2023-05-23 16:36 ` Thomas Monjalon
2023-05-23 19:00 ` Philip Prindeville
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).