patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2] examples/multi_process: fix compilation error on FreeBSD
       [not found] <1559725576-6427-1-git-send-email-david.marchand@redhat.com>
@ 2019-06-05 11:30 ` David Marchand
  2019-06-05 12:50   ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2019-06-05 11:30 UTC (permalink / raw)
  To: dev; +Cc: thomas, bruce.richardson, stable, Anatoly Burakov

Caught on FreeBSD 12:

/usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
  struct in_addr ip_src,ip_dst; /* source and dest address */
                 ^~~~~~

On FreeBSD, netinet/ip.h is not auto sufficient like on Linux.
But actually, this header is not used in the example, just remove it.

Fixes: 764bf26873b9 ("add FreeBSD support")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changelog since v1:
- took the opposite approach, rather than fix the netinet/ip.h inclusion,
  dropped it as it is unused
- added Fixes: tag

---
 examples/multi_process/client_server_mp/mp_server/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c
index 9a8e422..0150533 100644
--- a/examples/multi_process/client_server_mp/mp_server/main.c
+++ b/examples/multi_process/client_server_mp/mp_server/main.c
@@ -11,7 +11,6 @@
 #include <inttypes.h>
 #include <sys/queue.h>
 #include <errno.h>
-#include <netinet/ip.h>
 #include <signal.h>
 
 #include <rte_common.h>
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH v2] examples/multi_process: fix compilation error on FreeBSD
  2019-06-05 11:30 ` [dpdk-stable] [PATCH v2] examples/multi_process: fix compilation error on FreeBSD David Marchand
@ 2019-06-05 12:50   ` Bruce Richardson
  2019-06-05 13:14     ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2019-06-05 12:50 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, thomas, stable, Anatoly Burakov

On Wed, Jun 05, 2019 at 01:30:26PM +0200, David Marchand wrote:
> Caught on FreeBSD 12:
> 
> /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
>   struct in_addr ip_src,ip_dst; /* source and dest address */
>                  ^~~~~~
> 
> On FreeBSD, netinet/ip.h is not auto sufficient like on Linux.
> But actually, this header is not used in the example, just remove it.
> 
> Fixes: 764bf26873b9 ("add FreeBSD support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Tested-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

This should knock off one of the CI build errors once merged, I hope!
Thanks for doing the patch.

/Bruce

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH v2] examples/multi_process: fix compilation error on FreeBSD
  2019-06-05 12:50   ` Bruce Richardson
@ 2019-06-05 13:14     ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-06-05 13:14 UTC (permalink / raw)
  To: David Marchand; +Cc: Bruce Richardson, dev, stable, Anatoly Burakov

05/06/2019 14:50, Bruce Richardson:
> On Wed, Jun 05, 2019 at 01:30:26PM +0200, David Marchand wrote:
> > Caught on FreeBSD 12:
> > 
> > /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete type
> >   struct in_addr ip_src,ip_dst; /* source and dest address */
> >                  ^~~~~~
> > 
> > On FreeBSD, netinet/ip.h is not auto sufficient like on Linux.
> > But actually, this header is not used in the example, just remove it.
> > 
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> This should knock off one of the CI build errors once merged, I hope!
> Thanks for doing the patch.

Applied, thanks



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-05 13:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1559725576-6427-1-git-send-email-david.marchand@redhat.com>
2019-06-05 11:30 ` [dpdk-stable] [PATCH v2] examples/multi_process: fix compilation error on FreeBSD David Marchand
2019-06-05 12:50   ` Bruce Richardson
2019-06-05 13:14     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).