From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60074.outbound.protection.outlook.com [40.107.6.74]) by dpdk.org (Postfix) with ESMTP id 2A5832C18 for ; Mon, 4 Mar 2019 20:19:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xcXbxKZ9fuK1xjcg2U83jtP0OrzgB5GIlaGA5zmz+3s=; b=S5tTI2ALjohti6qC+bzX9jZm+0qpm+JuSFX1gYzOwab6imCJR+IjlyOWvgIgd1rVn6bTUcOd8f4UbK9BjgsV7eyQK3lFN5PLA7MI/yTHGk5TsFIFfSjFFHbuiElt5/wQdg/id5ffecTH+liOhPe3pH4goeZveuZjOr+rS0QvG9Q= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3995.eurprd05.prod.outlook.com (52.134.72.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.19; Mon, 4 Mar 2019 19:19:56 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50%3]) with mapi id 15.20.1665.020; Mon, 4 Mar 2019 19:19:56 +0000 From: Yongseok Koh To: Maxime Coquelin CC: "stable@dpdk.org" , Ilya Maximets Thread-Topic: [PATCH v17.11 LTS] vhost: fix payload size of reply Thread-Index: AQHUzbz+XydhZdZuNkeNvtEyjQ3C+KX74wYA Date: Mon, 4 Mar 2019 19:19:56 +0000 Message-ID: <3F772C53-0BFD-4F04-A4FE-DE311ADC8930@mellanox.com> References: <20190226102101.1454-1-maxime.coquelin@redhat.com> In-Reply-To: <20190226102101.1454-1-maxime.coquelin@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 609e6be7-2bbd-4662-34c8-08d6a0d6634d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3995; x-ms-traffictypediagnostic: DB3PR0502MB3995: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; DB3PR0502MB3995; 23:KgRkVhwA+EzSA9NK8YNgR0rScf+Ft7fFzunZmD+?= =?us-ascii?Q?JnVuIPgrs+440w9dKLqToYpjmA609B4RPBfRIqZqcZnfypltC1sWoCc2BKbQ?= =?us-ascii?Q?PweWw8Zqh6nQTmplRwWa9uKmfFDgUcRSJkDdsn2/Y1hjH5Nj9MFgjn0Hm9mz?= =?us-ascii?Q?rRmzLIdMOWmryEkDChzMS/ituaTy170cLfm2awy6zMzK+cBKWXH2KNi41zg+?= =?us-ascii?Q?GySj+IABTVuK2SCcpvsUOvvyQ5jPErb3/nenDcnme8XWHWjPIfEzNNcY21Gs?= =?us-ascii?Q?OxRDSyt14+eC1+Ft8ZFqzEdfnilK7ywJFOhng6CPwWD6hpvOnseXfLr0qoER?= =?us-ascii?Q?7V35Sa54yE5RcwhDmNXLzcf3PkSjrHt3+DTmyDBCi9JUJMbP6bLR+Nc8Wo5h?= =?us-ascii?Q?mc9v0NzMUgvgm2attu6+NmHHroze/yY/1RaO/S5PE9tmwQKThPGSyLJAqev8?= =?us-ascii?Q?WslcsHZRjbAhWAlG7E8BxAIoyqOIPxAv/m/1eA9yGKoM5gIwOaVXItzNZ+jv?= =?us-ascii?Q?qMu8bqmYC2jRm7RUe3gnTEftvBpcEjBOrMAJcqXpQPm8aYnjvszJ9Q9/oH2C?= =?us-ascii?Q?mWd83ihY9zMP5+LVVG5rY0JqzVIHBW4DZNpdZGGDxi05YSYB6Xhaq+lSKqGI?= =?us-ascii?Q?vCKqN6iAKhjxwAKR0p7zUPELU6YPxTwTb414JhsztVUApyr3moaLcFjAiivT?= =?us-ascii?Q?c2x+YLw2H63aBYsouTAn2399jsQGg6Pxf/46nfHwMM4ViX3+GD+dlqKhPZbi?= =?us-ascii?Q?XNDvuoW6zUB1XWcfJ7saxi4gJTvbTGOp/MEbq5ahKCvjT9pyQPeA1BbKk53y?= =?us-ascii?Q?8S3S5eqBQ/x2Z7E/VRWcsvOzGSYFGP802co8GpqjgvsYMQlClkJmptdGxBxg?= =?us-ascii?Q?AONQhkGpsZi4brarg/Xqvu362HK/L2zZHYemZoR2dzJk02tCWOkxxGAZ2NM7?= =?us-ascii?Q?h3mWO9gzIhIxXp2EcIbso7YOMQXbfELsG5/CLhZ6Kz5XxOAOuVFhVxl71mOk?= =?us-ascii?Q?KNOE8vPhy5SiwX4zPB/KMNlExhJtt4tg2eDZdOoLGzj10ixQhUnifERwN+rk?= =?us-ascii?Q?0hFXrxdV9J8t3NHWg7UCCShYsJL8F7m52VeIKSJDwHl7UdH8gvciGniwtt+1?= =?us-ascii?Q?R+Tj9efqEw0wf+fETiV7rQ/rIbFlcjNRCDQkc2bTvjtXEtuQY807K3gYHFOV?= =?us-ascii?Q?AVbtCJG5Tez/L8E+D92+V3MC2eNA5L2gEtCaQxBmXlADoNKHBKLUiarPMKNM?= =?us-ascii?Q?mDKFiEHGcUxy5SYnzrM2fNEIuAyZrtpuVmjHDypem?= x-microsoft-antispam-prvs: x-forefront-prvs: 09669DB681 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(376002)(346002)(366004)(136003)(199004)(189003)(6116002)(26005)(102836004)(68736007)(3846002)(305945005)(7736002)(8936002)(25786009)(36756003)(4326008)(81156014)(81166006)(54906003)(8676002)(99286004)(316002)(33656002)(6506007)(53546011)(82746002)(2906002)(14454004)(86362001)(76176011)(478600001)(2616005)(66066001)(186003)(476003)(11346002)(5660300002)(6512007)(229853002)(486006)(6486002)(6436002)(446003)(106356001)(14444005)(256004)(105586002)(97736004)(53936002)(71190400001)(71200400001)(6916009)(6246003)(83716004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3995; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: k49G4YhHt7G1DZFLHV0Z+zAs9ijCPU/N17hkAWpIGl2PE4R/e+C7fa9BQ6mgYPV++a94lGrC/hXmcMM1yGY7TkgXDjYsA3YokEEYJWyolCTnHY0gfUhrulmBIQ3NC9bwk58eYt66lebD5YZIhatu7AoGQ5lMBhkKHN6SEeFoohLdd0DRrkNw2TsryMgoqLYyF/NitimDjY0In/Wk57C0iD0c4dCnGkiwVuAZq8mjRzkCQkRyejc1iwZOSzLo8fXipy7wLOf+yfjzd6y6hTphwoe27TnYO1AQkBs41b79fzfVLaCcPeFWsspwu6pkj0yGy1tJYiCsuLgAW/8A71QNMl48BHUCC0ONZXNzZHJuUljiyqUDiJnu1AoKiqm2ZCtmtJJ01EZA0OATOBYjrLQEYiBV3gFdenhyVd+f1/1zAOg= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 609e6be7-2bbd-4662-34c8-08d6a0d6634d X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2019 19:19:56.8403 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3995 Subject: Re: [dpdk-stable] [PATCH v17.11 LTS] vhost: fix payload size of reply X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 19:19:58 -0000 > On Feb 26, 2019, at 2:21 AM, Maxime Coquelin = wrote: >=20 > [ upstream commit 57b4d90b5893db2678ca3e28c50e1fcd37bb9b91 ] >=20 > QEMU doesn't expect any payload for the reply of > VHOST_USER_SET_LOG_BASE request, so don't send any. > Note that the Vhost-user specification isn't clear about > it and would need to be fixed. >=20 > Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request") > Cc: stable@dpdk.org >=20 > Reported-by: Ilya Maximets > Signed-off-by: Maxime Coquelin > Acked-by: Ilya Maximets > Signed-off-by: Maxime Coquelin > --- Applied to stable/17.11 Thanks, Yongseok > lib/librte_vhost/vhost_user.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.= c > index d70778b22..74c286e34 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -1437,8 +1437,11 @@ vhost_user_msg_handler(int vid, int fd) > case VHOST_USER_SET_LOG_BASE: > vhost_user_set_log_base(dev, &msg); >=20 > - /* it needs a reply */ > - msg.size =3D sizeof(msg.payload.u64); > + /* > + * The spec is not clear about it (yet), but QEMU doesn't > + * expect any payload in the reply. > + */ > + msg.size =3D 0; > send_vhost_reply(fd, &msg); > break; > case VHOST_USER_SET_LOG_FD: > --=20 > 2.20.1 >=20