From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35860A0A02 for ; Tue, 27 Apr 2021 18:44:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26A834003E; Tue, 27 Apr 2021 18:44:17 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 73CF24003E; Tue, 27 Apr 2021 18:44:15 +0200 (CEST) IronPort-SDR: ZmISRgMAU18GQg9UsWoY1TSqKoTFYjdskp8D9edIjnVLC0th3NbKkN4iP6p7UBRH1e6FMJzeDl FsxuTRX03N4g== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="176030233" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="176030233" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 09:44:13 -0700 IronPort-SDR: wGPNEmSc89eOYWwgx6a6Hwi+ukevEWEVGDOUSCZ9/GhH6Y1ZbHC4NaFPZj8h5EzJh1DgxPwvJ0 b5r8ndsYHCtw== X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="457737713" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.221.231]) ([10.213.221.231]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 09:44:11 -0700 To: Jiawen Wu , dev@dpdk.org Cc: stable@dpdk.org References: <20210425080347.20376-1-jiawenwu@trustnetic.com> <20210425080347.20376-3-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <3a7b4c16-1bb7-8959-b2bc-62ea9dd16ede@intel.com> Date: Tue, 27 Apr 2021 17:44:09 +0100 MIME-Version: 1.0 In-Reply-To: <20210425080347.20376-3-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH 2/4] net/txgbe: fix VF MTU limit setting X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 4/25/2021 9:03 AM, Jiawen Wu wrote: > Fix to set MTU bigger than mbuf size when device is stopped, scattered > rx may be enabled in next starting, exempt from setting in EAL parameters. > The main change is 'dev_started' check, right? Can you please reword above paragraph to clarify it? > Fixes: a2beaa4a769e ("net/txgbe: support VF MTU update") > Cc: stable@dpdk.org > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/txgbe_ethdev_vf.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/txgbe/txgbe_ethdev_vf.c b/drivers/net/txgbe/txgbe_ethdev_vf.c > index 3a5123733e..5597968e18 100644 > --- a/drivers/net/txgbe/txgbe_ethdev_vf.c > +++ b/drivers/net/txgbe/txgbe_ethdev_vf.c > @@ -1115,7 +1115,7 @@ txgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) > { > struct txgbe_hw *hw; > uint32_t max_frame = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN; > - struct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode; > + struct rte_eth_dev_data *dev_data = dev->data; > > hw = TXGBE_DEV_HW(dev); > > @@ -1123,13 +1123,15 @@ txgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) > max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN) > return -EINVAL; > > - /* refuse mtu that requires the support of scattered packets when this > - * feature has not been enabled before. > + /* If device is started, refuse mtu that requires the support of > + * scattered packets when this feature has not been enabled before. > */ > - if (!(rx_conf->offloads & DEV_RX_OFFLOAD_SCATTER) && > + if (dev_data->dev_started && !dev_data->scattered_rx && > (max_frame + 2 * TXGBE_VLAN_TAG_SIZE > > - dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM)) > + dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM)) { > + PMD_INIT_LOG(ERR, "Stop port first."); > return -EINVAL; > + } > > /* > * When supported by the underlying PF driver, use the TXGBE_VF_SET_MTU >