From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BC08A034F for ; Wed, 13 May 2020 09:03:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 121D91C22E; Wed, 13 May 2020 09:03:35 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id ABC651C1C9; Wed, 13 May 2020 09:03:31 +0200 (CEST) IronPort-SDR: +nhAzK0puJZ+bWl1n3d9IyREN9C47ST02bLKwnFB9je6Zc61bZF+DWWNtVcMoL9x8z480hYSJX KioGw2E81vCg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 00:03:30 -0700 IronPort-SDR: beBWceq3E91zDKJJk0wLBo2cLQh+URvo9jY/on4cqXhSO1gre3EyaqsoUJycb6gY17hCzTC4ME o3KXVKLxLrWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,386,1583222400"; d="scan'208";a="262386161" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 13 May 2020 00:03:30 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 00:03:30 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 13 May 2020 15:03:27 +0800 Received: from shsmsx604.ccr.corp.intel.com ([10.109.6.214]) by SHSMSX604.ccr.corp.intel.com ([10.109.6.214]) with mapi id 15.01.1713.004; Wed, 13 May 2020 15:03:27 +0800 From: "Jiang, YuX" To: "Ye, Xiaolong" , "Sun, GuinanX" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics error in flow control mode Thread-Index: AQHWKMLskrpucqQaoU2IIuwq0jM4Aaill46g Date: Wed, 13 May 2020 07:03:27 +0000 Message-ID: <3bfd55a5921040b198731c4da4b3197d@intel.com> References: <20200508082939.32525-1-guinanx.sun@intel.com> <20200512081306.16013-1-guinanx.sun@intel.com> <20200513005918.GS75514@intel.com> In-Reply-To: <20200513005918.GS75514@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Tested-by: Jiang, YuX -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ye Xiaolong Sent: Wednesday, May 13, 2020 8:59 AM To: Sun, GuinanX Cc: dev@dpdk.org; stable@dpdk.org Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics = error in flow control mode On 05/12, Guinan Sun wrote: >The register autoneg can't be updated synchronously with flow control=20 >mode setting in the state of port start , so NIC statistics error=20 >occurs. AUTO_NEG Advt register should be updated by ixgbe_setup_fc()=20 >when enabling flow control. >The patch fixes the issue. > >Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") >Cc: stable@dpdk.org > >Signed-off-by: Guinan Sun >--- >v2 changes: >* Replaced mac.ops.setup_fc() with ixgbe_setup_fc() >* Modified commit message. >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c=20 >b/drivers/net/ixgbe/ixgbe_ethdev.c >index a4e5c539d..f8a84c565 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.c >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c >@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, stru= ct ixgbe_hw *hw) > int err; > uint32_t mflcn; >=20 >+ ixgbe_setup_fc(hw); >+ > err =3D ixgbe_fc_enable(hw); >=20 > /* Not negotiated is not an error case */ >-- >2.17.1 > Applied to dpdk-next-net-intel, Thanks.