From: Ferruh Yigit <ferruh.yigit@intel.com> To: Fang TongHao <fangtonghao@sangfor.com.cn>, thomas@monjalon.net, arybchenko@solarflare.com Cc: dev@dpdk.org, stable@dpdk.org, jia.guo@intel.com, cunming.liang@intel.com, qi.z.zhang@intel.com, jungle845943968@outlook.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] Fixes: ethdev: secondary process change shared memory Date: Tue, 14 Jan 2020 14:45:33 +0000 Message-ID: <3c3022b0-aa8d-1404-0a6c-21a86ab6f9d7@intel.com> (raw) In-Reply-To: <20200113050312.1506-1-fangtonghao@sangfor.com.cn> On 1/13/2020 5:03 AM, Fang TongHao wrote: > Secondary process calls “rte_eth_dev_pci_allocate” > function and enters rte_eth_copy_pci_info function > when initializing.Then it sets the value of struct > "rte_eth_dev_data.dev_flags" to zero and reset it, > but this struct is shared by primary process and > secondary process.To fix this bug,by adding an > if-statement to forbid the secondaryprocess changing > the above-mentioned value. Hi Fang, Thanks for the fix, I agree with the problem statement, but not sure if this should be handled in the helper function or in the place where the function is called. Helper function is simple on what it does, do we need to put the primary process logic in it. Can you please give more details of the bug you have encounter, is it seen by a specific PMD? Thanks, ferruh > > Signed-off-by: Fang TongHao <fangtonghao@sangfor.com.cn> > --- > lib/librte_ethdev/rte_ethdev_pci.h | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h > index ccdbb46ec..e7dae0545 100644 > --- a/lib/librte_ethdev/rte_ethdev_pci.h > +++ b/lib/librte_ethdev/rte_ethdev_pci.h > @@ -60,14 +60,16 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev, > > eth_dev->intr_handle = &pci_dev->intr_handle; > > - eth_dev->data->dev_flags = 0; > - if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC) > - eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC; > - if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_RMV) > - eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_RMV; > - > - eth_dev->data->kdrv = pci_dev->kdrv; > - eth_dev->data->numa_node = pci_dev->device.numa_node; > + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > + eth_dev->data->dev_flags = 0; > + if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC) > + eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC; > + if (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_RMV) > + eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_RMV; > + > + eth_dev->data->kdrv = pci_dev->kdrv; > + eth_dev->data->numa_node = pci_dev->device.numa_node; > + } > } > > static inline int >
next prev parent reply other threads:[~2020-01-14 14:45 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-09 12:27 [dpdk-stable] [PATCH] ethdev: fix secondary process change share memory Fang TongHao 2020-01-10 7:30 ` Jeff Guo 2020-01-10 7:53 ` 方统浩50450 2020-01-13 5:03 ` [dpdk-stable] [PATCH v2] Fixes: ethdev: secondary process change shared memory Fang TongHao 2020-01-14 14:45 ` Ferruh Yigit [this message] 2020-01-15 6:49 ` [dpdk-stable] [dpdk-dev] " 方统浩50450 2020-01-15 18:35 ` Ferruh Yigit 2020-01-15 20:43 ` Thomas Monjalon 2020-01-16 7:43 ` Andrew Rybchenko 2020-01-16 9:04 ` Ferruh Yigit 2020-01-16 11:35 ` 方统浩50450 2020-01-16 12:18 ` Ferruh Yigit 2020-01-17 2:11 ` 方统浩50450 2020-01-16 9:00 ` Ferruh Yigit 2020-01-17 2:08 ` [dpdk-stable] [PATCH v3] " Fang TongHao 2020-01-17 8:33 ` Andrew Rybchenko 2020-01-17 17:58 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3c3022b0-aa8d-1404-0a6c-21a86ab6f9d7@intel.com \ --to=ferruh.yigit@intel.com \ --cc=arybchenko@solarflare.com \ --cc=cunming.liang@intel.com \ --cc=dev@dpdk.org \ --cc=fangtonghao@sangfor.com.cn \ --cc=jia.guo@intel.com \ --cc=jungle845943968@outlook.com \ --cc=qi.z.zhang@intel.com \ --cc=stable@dpdk.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git