From: Ferruh Yigit <ferruh.yigit@intel.com>
To: wangyunjian <wangyunjian@huawei.com>,
Jerin Jacob <jerinjacobk@gmail.com>,
Rasesh Mody <rmody@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Shahed Shaikh <shshaikh@marvell.com>,
"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
xudingke <xudingke@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [EXT] [PATCH] net/qede: remove dead code
Date: Wed, 22 Jul 2020 13:29:49 +0100 [thread overview]
Message-ID: <3cdb4631-879d-b552-8220-dd1b7a7a8072@intel.com> (raw)
In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60D0DD6DF@DGGEMM533-MBX.china.huawei.com>
On 7/22/2020 1:15 PM, wangyunjian wrote:
>> -----Original Message-----
>> From: Jerin Jacob [mailto:jerinjacobk@gmail.com]
>> Sent: Wednesday, July 22, 2020 3:45 PM
>> To: Rasesh Mody <rmody@marvell.com>
>> Cc: wangyunjian <wangyunjian@huawei.com>; dev@dpdk.org; Shahed Shaikh
>> <shshaikh@marvell.com>; Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke
>> <xudingke@huawei.com>; stable@dpdk.org
>> Subject: Re: [EXT] [dpdk-dev] [PATCH] net/qede: remove dead code
>>
>> On Wed, Jul 22, 2020 at 3:14 AM Rasesh Mody <rmody@marvell.com> wrote:
>>>
>>>> From: wangyunjian <wangyunjian@huawei.com>
>>>> Sent: Friday, July 17, 2020 4:16 AM
>>>>
>>>> From: Yunjian Wang <wangyunjian@huawei.com>
>>>>
>>>> This patch fixes (Logically dead code) coverity issue.
>>>>
>>>> Coverity issue: 261777, 261778
>>>> Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>>>> ---
>>>
>>> Acked-by: Rasesh Mody <rmody@marvell.com>
>>
>> There is build issue reported with this patch by CI for qede. Please check it is
>> valid or not http://mails.dpdk.org/archives/test-report/2020-July/145267.html
>
> I've already checked. I don't know the reason why the codes on both sides are different.
>
> The origin code:
> fprintf(stderr,"Can not write all of dump data bytes=%zd len=%zd\n",
>
> The CI code:
> fprintf(stderr, "Can not write all of dump data bytes=%ld len=%ld\n",
>
CI run is on top of the 'mrvl' tree (DPDK git baseline:
Repo:dpdk-next-net-mrvl), and above part may be fixed while pulling to the
'next-net'.
Anyway the latest code looks good (for above change), also the error is
unrelated to your patch. So a false positive for this patch.
next prev parent reply other threads:[~2020-07-22 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 11:16 [dpdk-stable] [dpdk-dev] " wangyunjian
2020-07-21 12:12 ` Jerin Jacob
2020-07-21 21:43 ` [dpdk-stable] [EXT] " Rasesh Mody
2020-07-22 7:45 ` Jerin Jacob
2020-07-22 12:15 ` wangyunjian
2020-07-22 12:29 ` Ferruh Yigit [this message]
2020-07-24 4:23 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cdb4631-879d-b552-8220-dd1b7a7a8072@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=jerry.lilijun@huawei.com \
--cc=rmody@marvell.com \
--cc=shshaikh@marvell.com \
--cc=stable@dpdk.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).