From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C8F9FA0096 for ; Fri, 12 Apr 2019 11:21:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A08775B34; Fri, 12 Apr 2019 11:21:06 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id A30045B34 for ; Fri, 12 Apr 2019 11:21:05 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id g3so10966763wrx.9 for ; Fri, 12 Apr 2019 02:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=sVrudwwwtV3MjFPZJOhyR7stJkvhNsANfOJpxBehqg4=; b=AXbY/62JnmeAQYlJlOaliCruPl/7Tov3hbpzLyKemZnA2H3gBktpJBMs365VjOW+4u +30sS8UvhCGdUBCJwZP1U3LI0TwjA/r+7bhTCqomfB+TvY8FWhhdglcjme1jfr2hcH6v nRQhVWuNPjL0pu4YF1cte64bPFl+34HVwmRZ+sVEk/ky3NvJ6TqbTixxBGuL3HHBFxpQ MIC5avWh0wJiTqZ2yv+pRJQF8VwFypXs1yvgfOIaQ7LRhCkSY219Vv8fpFfJ7zhjS69q ajeGq9GXPZNRXKXsHPWrb45RLHAupZQpSf8OVQlksUbpY7g//jTW/leaG1GQ7Ci3Axbh 06Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=sVrudwwwtV3MjFPZJOhyR7stJkvhNsANfOJpxBehqg4=; b=VtbapzQN7HntFvIARBSw6b8i0jd1TMmusJdliZMdS6V2QhTO1Q2Ud2DkEcwGUmw+Xz SCc3VyThxD4BqZr7L0b/hQYEy3KvKHgKhWW6LyE8d0B46n32/yiiIxNV6cgqNPk0qi0T dIXzM6BPM7rvBZYEdNnr+jnZsPtyFZziidg00mOSI7q8nwbBbgUuetJyUit2TdiHmHvJ 9ejTsGBQU+aYincZMipoaXtmCNFBzMxBK494RVKK0JWlWmQSj/Xyw4LVyplX7tp6cTEj HVvWfvaEjQkOfZ3hb02y2Qf+oRY6dZAjls9/kyc80twuy1Qtjdvl5YOPfQ4wjj1tmz6Q v8bw== X-Gm-Message-State: APjAAAVDUpfnAursIeWYxe3ElEEodltvRgaRwJdadUdHjZR5BvzborpT mjK/GiwzHrYmcpyNYnK8LZ87EepeASM= X-Google-Smtp-Source: APXvYqwZKSO3snnrA61BhBDtBGOKz6X0S79td+D+Ft7nJII3qYeDpO1vfXx179k/npgMFPW++8KNmg== X-Received: by 2002:adf:df0f:: with SMTP id y15mr14037109wrl.175.1555060865102; Fri, 12 Apr 2019 02:21:05 -0700 (PDT) Received: from [172.20.1.137] ([217.38.71.146]) by smtp.googlemail.com with ESMTPSA id z11sm8233469wmf.12.2019.04.12.02.21.03 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 12 Apr 2019 02:21:03 -0700 (PDT) To: stable@dpdk.org References: <1552059647-2725-1-git-send-email-pablo.cascon@netronome.com> From: =?UTF-8?Q?Pablo_Casc=c3=b3n?= Message-ID: <3d8737af-cdcf-e6a1-970d-8a00ae9b831b@netronome.com> Date: Fri, 12 Apr 2019 10:21:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1552059647-2725-1-git-send-email-pablo.cascon@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [dpdk-stable] [PATCH 1/1] net/nfp: fix set_mac_addr X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 08/03/2019 15:40, Pablo Cascón wrote: > Some firmwares, mostly for VFs, do not advertise the feature / > capability of changing the MAC address while the interface is up. With > such firmware a request to change the MAC address that at the same > time also tries to enable the not available feature will be denied by > the firmware resulting in an error message like: > > nfp_net_reconfig(): Error nfp_net reconfig for ctrl: 80000000 update: 800 > > Fix set_mac_addr by not trying to enable a feature if it is not > advertised by the firmware. > > Fixes: 2fe669f4bcd2 ("net/nfp: support MAC address change") > > Signed-off-by: Pablo Cascón > --- > drivers/net/nfp/nfp_net.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 54c6da9..278e154 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -566,7 +566,10 @@ nfp_set_mac_addr(struct rte_eth_dev *dev, struct ether_addr *mac_addr) > > /* Signal the NIC about the change */ > update = NFP_NET_CFG_UPDATE_MACADDR; > - ctrl = hw->ctrl | NFP_NET_CFG_CTRL_LIVE_ADDR; > + ctrl = hw->ctrl; > + if ((hw->ctrl & NFP_NET_CFG_CTRL_ENABLE) && > + (hw->cap & NFP_NET_CFG_CTRL_LIVE_ADDR)) > + ctrl |= NFP_NET_CFG_CTRL_LIVE_ADDR; > if (nfp_net_reconfig(hw, ctrl, update) < 0) { > PMD_INIT_LOG(INFO, "MAC address update failed"); > return -EIO; Hello, just checking if this patch is being considered for stable. Thanks