[PATCH 19.11.14-rc1 LTS] app/testpmd: fix compile error

[PATCH 19.11.14-rc1 LTS] app/testpmd: fix compile error

[Ke Zhang]

[ upstream commit f99f2e55af7a49a6ee6555a5554847094086017f]

variable 'c' is set but not used, it should be cleard.

Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")

Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
---
 app/test-pmd/config.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 9f96e77ba3..a04ce0ec64 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1457,7 +1457,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule)
 {
 	struct rte_port *port;
 	struct port_flow **tmp;
-	uint32_t c = 0;
 	int ret = 0;
 
 	if (port_id_is_invalid(port_id, ENABLED_WARN) ||
@@ -1490,7 +1489,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule)
 		}
 		if (i == n)
 			tmp = &(*tmp)->next;
-		++c;
 	}
 	return ret;
 }
-- 
2.25.1

Re: [PATCH 19.11.14-rc1 LTS] app/testpmd: fix compile error

[Kevin Traynor]

On 08/02/2023 05:45, Ke Zhang wrote:
> [ upstream commit f99f2e55af7a49a6ee6555a5554847094086017f]
> 

Hi,

DPDK 19.11 LTS is EOL. Please see: https://core.dpdk.org/roadmap/#stable

For reference, the named commit does not exist in dpdk main. It looks 
like the patch is a rebase of:

commit 2809981e858f5cfa3ea9182e400a2c67f7c4744d
Author: David Marchand <david.marchand@redhat.com>
Date:   Fri Nov 18 09:53:10 2022 +0100

     app/testpmd: fix build with clang 15 in flow code

     This variable is not used and has been copy/pasted in a lot of other
     code.

     Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow 
API")


> variable 'c' is set but not used, it should be cleard.
> 
> Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API")
> 
> Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> ---
>   app/test-pmd/config.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 9f96e77ba3..a04ce0ec64 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1457,7 +1457,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule)
>   {
>   	struct rte_port *port;
>   	struct port_flow **tmp;
> -	uint32_t c = 0;
>   	int ret = 0;
>   
>   	if (port_id_is_invalid(port_id, ENABLED_WARN) ||
> @@ -1490,7 +1489,6 @@ port_flow_destroy(portid_t port_id, uint32_t n, const uint32_t *rule)
>   		}
>   		if (i == n)
>   			tmp = &(*tmp)->next;
> -		++c;
>   	}
>   	return ret;
>   }