From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Ferriter, Cian" <cian.ferriter@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/pcap: fix infinite Rx with large files
Date: Thu, 4 Feb 2021 17:12:38 +0000 [thread overview]
Message-ID: <3e03c37b-0a93-7112-f3e4-eb57ddccc1fc@intel.com> (raw)
In-Reply-To: <BYAPR11MB37516F00406057B99CB152A4EDB39@BYAPR11MB3751.namprd11.prod.outlook.com>
On 2/4/2021 5:02 PM, Ferriter, Cian wrote:
> The new error message looks great.
>
> As I've already given my ack, I'm happy for this to be applied.
>
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Thursday 4 February 2021 16:51
>> To: Ferriter, Cian <cian.ferriter@intel.com>
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org; stable@dpdk.org
>> Subject: [PATCH v2] net/pcap: fix infinite Rx with large files
>>
>> Packet forwarding is not working when infinite Rx feature is used with
>> large .pcap files that has high number of packets.
>>
>> The problem is number of allocated mbufs are less than the infinite Rx
>> ring size, and all mbufs consumed to fill the ring, so there is no mbuf
>> left for forwarding.
>>
>> Current logic can not detect that infinite Rx ring is not filled
>> completely and no more mbufs left, and setup continues which leads
>> silent fail on packet forwarding.
>>
>> There isn't much can be done when there is not enough mbuf for the given
>> .pcap file, so additional checks added to detect the case and fail
>> explicitly with an error log.
>>
>> Bugzilla ID: 595
>> Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file")
>> Cc: stable@dpdk.org
>>
>> Reported-by: Cian Ferriter <cian.ferriter@intel.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Acked-by: Cian Ferriter <cian.ferriter@intel.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2021-02-04 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 15:49 [dpdk-stable] [PATCH] " Ferruh Yigit
2021-02-04 16:03 ` Ferriter, Cian
2021-02-04 16:28 ` Ferruh Yigit
2021-02-04 17:01 ` Ferriter, Cian
2021-02-04 16:51 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit
2021-02-04 17:02 ` Ferriter, Cian
2021-02-04 17:12 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e03c37b-0a93-7112-f3e4-eb57ddccc1fc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cian.ferriter@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).