From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C849A09E4 for ; Thu, 4 Feb 2021 18:12:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0323F240715; Thu, 4 Feb 2021 18:12:49 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 086D42406DD; Thu, 4 Feb 2021 18:12:45 +0100 (CET) IronPort-SDR: 6Uj9kzL7njZ9gVEs2y2vtwUni3fcvRH+L3Iy5Au+hgZnZn1FFD2qna5H0myYUQ8OODz7GrvCkN dCL6kAmCbmIw== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="181434736" X-IronPort-AV: E=Sophos;i="5.81,401,1610438400"; d="scan'208";a="181434736" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 09:12:43 -0800 IronPort-SDR: Arm7JHCr1Zk9fg2EYCX3dBmzQi7RjzU0j7RMo8tMP9cljYtINJcvQBu93zYphpienQQE/fKhL/ 4S4K6CgNfG+g== X-IronPort-AV: E=Sophos;i="5.81,401,1610438400"; d="scan'208";a="393282844" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.211.210]) ([10.213.211.210]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 09:12:42 -0800 To: "Ferriter, Cian" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20210203154920.2449179-1-ferruh.yigit@intel.com> <20210204165103.2355136-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <3e03c37b-0a93-7112-f3e4-eb57ddccc1fc@intel.com> Date: Thu, 4 Feb 2021 17:12:38 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v2] net/pcap: fix infinite Rx with large files X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 2/4/2021 5:02 PM, Ferriter, Cian wrote: > The new error message looks great. > > As I've already given my ack, I'm happy for this to be applied. > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Thursday 4 February 2021 16:51 >> To: Ferriter, Cian >> Cc: Yigit, Ferruh ; dev@dpdk.org; stable@dpdk.org >> Subject: [PATCH v2] net/pcap: fix infinite Rx with large files >> >> Packet forwarding is not working when infinite Rx feature is used with >> large .pcap files that has high number of packets. >> >> The problem is number of allocated mbufs are less than the infinite Rx >> ring size, and all mbufs consumed to fill the ring, so there is no mbuf >> left for forwarding. >> >> Current logic can not detect that infinite Rx ring is not filled >> completely and no more mbufs left, and setup continues which leads >> silent fail on packet forwarding. >> >> There isn't much can be done when there is not enough mbuf for the given >> .pcap file, so additional checks added to detect the case and fail >> explicitly with an error log. >> >> Bugzilla ID: 595 >> Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file") >> Cc: stable@dpdk.org >> >> Reported-by: Cian Ferriter >> Signed-off-by: Ferruh Yigit >> Acked-by: Cian Ferriter Applied to dpdk-next-net/main, thanks.