patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xueming Li <xuemingl@nvidia.com>, Matan Azrad <matan@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: dev@dpdk.org, Asaf Penso <asafp@nvidia.com>, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] common/mlx5: get number of ports that can be bonded
Date: Wed, 28 Oct 2020 10:30:14 +0100
Message-ID: <3ecc59a2-0800-46eb-26f4-030a0266295e@redhat.com> (raw)
In-Reply-To: <1603710656-32187-1-git-send-email-xuemingl@nvidia.com>

Hi,

On 10/26/20 12:10 PM, Xueming Li wrote:
> Get HCA capability: number of physical ports that can be bonded.
> 
> Cc: stable@dpdk.org

Is that a fix or a new feature? The commit title and description seem to
indicate the former. But stable ML being cc'ed seems to indicate the
latter.

If this is a fix, please describe what it is fixing, and add Fixes tag
pointing on the commit it is fixing.

Thanks,
Maxime

> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  drivers/common/mlx5/mlx5_devx_cmds.c | 5 +++--
>  drivers/common/mlx5/mlx5_devx_cmds.h | 1 +
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
> index 8aee12d527..e748d034d0 100644
> --- a/drivers/common/mlx5/mlx5_devx_cmds.c
> +++ b/drivers/common/mlx5/mlx5_devx_cmds.c
> @@ -711,6 +711,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
>  	attr->non_wire_sq = MLX5_GET(cmd_hca_cap, hcattr, non_wire_sq);
>  	attr->log_max_static_sq_wq = MLX5_GET(cmd_hca_cap, hcattr,
>  					      log_max_static_sq_wq);
> +	attr->num_lag_ports = MLX5_GET(cmd_hca_cap, hcattr, num_lag_ports);
>  	attr->dev_freq_khz = MLX5_GET(cmd_hca_cap, hcattr,
>  				      device_frequency_khz);
>  	attr->scatter_fcs_w_decap_disable =
> @@ -1429,8 +1430,8 @@ mlx5_devx_cmd_create_tis(void *ctx,
>  	tis_ctx = MLX5_ADDR_OF(create_tis_in, in, ctx);
>  	MLX5_SET(tisc, tis_ctx, strict_lag_tx_port_affinity,
>  		 tis_attr->strict_lag_tx_port_affinity);
> -	MLX5_SET(tisc, tis_ctx, strict_lag_tx_port_affinity,
> -		 tis_attr->strict_lag_tx_port_affinity);
> +	MLX5_SET(tisc, tis_ctx, lag_tx_port_affinity,
> +		 tis_attr->lag_tx_port_affinity);
>  	MLX5_SET(tisc, tis_ctx, prio, tis_attr->prio);
>  	MLX5_SET(tisc, tis_ctx, transport_domain,
>  		 tis_attr->transport_domain);
> diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h
> index abbea67784..3781fedd9e 100644
> --- a/drivers/common/mlx5/mlx5_devx_cmds.h
> +++ b/drivers/common/mlx5/mlx5_devx_cmds.h
> @@ -99,6 +99,7 @@ struct mlx5_hca_attr {
>  	uint32_t cross_channel:1;
>  	uint32_t non_wire_sq:1; /* SQ with non-wire ops is supported. */
>  	uint32_t log_max_static_sq_wq:5; /* Static WQE size SQ. */
> +	uint32_t num_lag_ports:4; /* Number of ports can be bonded. */
>  	uint32_t dev_freq_khz; /* Timestamp counter frequency, kHz. */
>  	uint32_t scatter_fcs_w_decap_disable:1;
>  	uint32_t regex:1;
> 


  parent reply	other threads:[~2020-10-28  9:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 11:10 [dpdk-stable] " Xueming Li
2020-10-26 11:10 ` [dpdk-stable] [PATCH 2/2] vdpa/mlx5: specify lag port affinity Xueming Li
2020-10-28  9:35   ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2020-10-28 10:32     ` Xueming(Steven) Li
2020-10-28  9:30 ` Maxime Coquelin [this message]
2020-10-28 10:44 ` [dpdk-stable] [PATCH v1 1/2] common/mlx5: get number of ports that can be bonded Xueming Li
2020-10-29  8:29   ` Maxime Coquelin
2020-10-28 10:44 ` [dpdk-stable] [PATCH v1 2/2] vdpa/mlx5: specify lag port affinity Xueming Li
2020-10-29  8:29   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ecc59a2-0800-46eb-26f4-030a0266295e@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git