From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4836A04DD for ; Wed, 28 Oct 2020 10:30:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C90FC85C; Wed, 28 Oct 2020 10:30:28 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 742E5C802 for ; Wed, 28 Oct 2020 10:30:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603877423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R7a0Nevd9aOhUnQFybO3e33nfqk1QY2fbsb25Z7vn5Y=; b=BXyauRuYwlZX31ACDkvz4NnpL+Nuu+WyftwEyc0vK85tNvNXH2nIqm2r4U9IEpuU98IexZ +z2AzC+g1fTQOuk7U+lkgC6ZpmCvd9tCuczDZhCLOjbX2G20IhRlPi4UnZ3I2uVnnBdMvq wwLK59sIwhKg0s3l75gGw1YPxzlt+vA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-531-kSEzmIAtOaeLe3tOgmbYnw-1; Wed, 28 Oct 2020 05:30:19 -0400 X-MC-Unique: kSEzmIAtOaeLe3tOgmbYnw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D8B98064D4; Wed, 28 Oct 2020 09:30:18 +0000 (UTC) Received: from [10.36.110.54] (unknown [10.36.110.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F0B060C11; Wed, 28 Oct 2020 09:30:16 +0000 (UTC) To: Xueming Li , Matan Azrad , Viacheslav Ovsiienko Cc: dev@dpdk.org, Asaf Penso , stable@dpdk.org References: <1603710656-32187-1-git-send-email-xuemingl@nvidia.com> From: Maxime Coquelin Message-ID: <3ecc59a2-0800-46eb-26f4-030a0266295e@redhat.com> Date: Wed, 28 Oct 2020 10:30:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <1603710656-32187-1-git-send-email-xuemingl@nvidia.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] common/mlx5: get number of ports that can be bonded X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, On 10/26/20 12:10 PM, Xueming Li wrote: > Get HCA capability: number of physical ports that can be bonded. > > Cc: stable@dpdk.org Is that a fix or a new feature? The commit title and description seem to indicate the former. But stable ML being cc'ed seems to indicate the latter. If this is a fix, please describe what it is fixing, and add Fixes tag pointing on the commit it is fixing. Thanks, Maxime > Signed-off-by: Xueming Li > Acked-by: Matan Azrad > --- > drivers/common/mlx5/mlx5_devx_cmds.c | 5 +++-- > drivers/common/mlx5/mlx5_devx_cmds.h | 1 + > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c > index 8aee12d527..e748d034d0 100644 > --- a/drivers/common/mlx5/mlx5_devx_cmds.c > +++ b/drivers/common/mlx5/mlx5_devx_cmds.c > @@ -711,6 +711,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx, > attr->non_wire_sq = MLX5_GET(cmd_hca_cap, hcattr, non_wire_sq); > attr->log_max_static_sq_wq = MLX5_GET(cmd_hca_cap, hcattr, > log_max_static_sq_wq); > + attr->num_lag_ports = MLX5_GET(cmd_hca_cap, hcattr, num_lag_ports); > attr->dev_freq_khz = MLX5_GET(cmd_hca_cap, hcattr, > device_frequency_khz); > attr->scatter_fcs_w_decap_disable = > @@ -1429,8 +1430,8 @@ mlx5_devx_cmd_create_tis(void *ctx, > tis_ctx = MLX5_ADDR_OF(create_tis_in, in, ctx); > MLX5_SET(tisc, tis_ctx, strict_lag_tx_port_affinity, > tis_attr->strict_lag_tx_port_affinity); > - MLX5_SET(tisc, tis_ctx, strict_lag_tx_port_affinity, > - tis_attr->strict_lag_tx_port_affinity); > + MLX5_SET(tisc, tis_ctx, lag_tx_port_affinity, > + tis_attr->lag_tx_port_affinity); > MLX5_SET(tisc, tis_ctx, prio, tis_attr->prio); > MLX5_SET(tisc, tis_ctx, transport_domain, > tis_attr->transport_domain); > diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h > index abbea67784..3781fedd9e 100644 > --- a/drivers/common/mlx5/mlx5_devx_cmds.h > +++ b/drivers/common/mlx5/mlx5_devx_cmds.h > @@ -99,6 +99,7 @@ struct mlx5_hca_attr { > uint32_t cross_channel:1; > uint32_t non_wire_sq:1; /* SQ with non-wire ops is supported. */ > uint32_t log_max_static_sq_wq:5; /* Static WQE size SQ. */ > + uint32_t num_lag_ports:4; /* Number of ports can be bonded. */ > uint32_t dev_freq_khz; /* Timestamp counter frequency, kHz. */ > uint32_t scatter_fcs_w_decap_disable:1; > uint32_t regex:1; >