patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"Xueming(Steven) Li" <xuemingl@nvidia.com>,
	Luca Boccassi <bluca@debian.org>,
	"Wang, Haiyue" <haiyue.wang@intel.com>,
	"christian.ehrhardt@canonical.com"
	<christian.ehrhardt@canonical.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>, "Fu, Qi" <qi.fu@intel.com>,
	techboard@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN design for Intel ice PMD
Date: Mon, 21 Jun 2021 11:28:14 +0100
Message-ID: <3f368eff-3fc5-0d9f-7eab-95a731ac110d@redhat.com> (raw)
In-Reply-To: <10618347.Fq3sR6fjhQ@thomas>

On 21/06/2021 09:28, Thomas Monjalon wrote:
> 18/06/2021 05:22, Wang, Haiyue:
>> From: Kevin Traynor <ktraynor@redhat.com>
>>> On 17/06/2021 09:53, Xueming(Steven) Li wrote:
>>>> From: Wang, Haiyue <haiyue.wang@intel.com>
>>>>> From: Luca Boccassi <bluca@debian.org>
>>>>>> On Fri, 2021-06-11 at 15:15 +0800, Haiyue Wang wrote:
>>>>>>> When LTS 20.11 was released, the Intel ice PMD has a basic VLAN
>>>>>>> offload, which can only handle single VLAN mode for firmware
>>>>>>> limitation. Now the firmware is updated to support double VLAN mode
>>>>>>> and single VLAN mode at the same time.
>>>>>>> It depends on the driver to do selection at the boot time.
>>>>>>>
>>>>>>> As VLAN protocol handling like strip, filter, flow is very common
>>>>>>> use, we request to support the ice PMD can run on the latest
>>>>>>> firmware for enabling the new design. This is compatible backport as the main tree.
> [...]
>>>>>>>  19 files changed, 1545 insertions(+), 363 deletions(-)  create mode
> [...]
>>>>>> At 1.9k diffstat, this series is quite large. Given it's a new
>>>>>> feature, rather than a series of bug fixes, this would seem a bit risky to me.
>>>>>> Final word of course belongs to Xueming, since he's managing this one.
> 
> [...]
>>>>> 06. Is it obvious that the feature will not impact existing functionality?
>>>>>
>>>>> Yes.
>>>
>>> No. It is 1.9KLOC change. The key part of the question is "obvious". It
>>> was meant so the maintainer could use their judgement and review that
>>> for example, a few lines of code adding a PCI ID or adding a case in a
>>> switch statement, is obviously not going to impact existing functionality.
>>> On the other hand, for a more complex code change to existing code, it
>>> is not immediately obvious that there would be no risk to existing
>>> functionality.
> 
> [...]
>>>>> 11. Is there a community consensus about the backport?
>>>>>
>>>>> ...
>>>>
>>>> Kevin happens to updated the documents on new feature backport 4 months ago, thanks for checking
>>> them
>>>> one by one. Luca's only concern is size of the series, driver vendor is on it's own risk to backport
>>> a big patch set.
>>>> The series supports new fw and QinQ, is it easy to split?
>>>>
>>>> Kevin, is this the first case of feature backport? How do you think?
>>>>
>>>
>>> Like Luca, main concern would be the size and intrusiveness of the
>>> changes, and if it's ok to change 1.9KLOC in this driver now, then why
>>> not 20KLOC in next release to multiple drivers. I had pushed against a
>>
>> TBH, we won't want to change the stable i40e, ixgbe PMDs, but ice is a fresh
>> one, current VLAN has a limited usage, customer is hard to use. That's why we
>> try to request to backport the new VLAN design.
> 
> Yes ice is quite recent.
> If a required feature is not working, it should motivate to upgrade.
> Because ice is "fresh", I don't understand why sticking to 20.11.
> My concern is that backporting this big feature would create a precedent,
> so all users will require to stick on the last LTS when getting
> all the new reworked features.
> I think it would be a bad situation for all of us.
> 
> 
> 

Why can't the users use ABI compatible 21.02/21.05? Why do they want to
stay on 20.11? The only reason I can see for staying on 20.11 is because
it is a stable (bug fix only) release.

So you want an LTS that is bug fix only except for ice with new features.

A type of LTS-main hybrid for selected drivers seems like something more
suited for individual vendors and not replacing the community LTS with IMHO.

But if it were to replace the current community LTS, or become the
normal, then it should be consciously decided. I feel doing it by adding
one big feature at a time to the current LTS is not the right approach.


  parent reply	other threads:[~2021-06-21 10:28 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11  6:58 [PATCH 20.11 v1 " Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 01/18] net/ice/base: align add VSI and update VSI AQ command buffer Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 02/18] net/ice/base: add interface to support configuring VLAN mode Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 03/18] net/ice/base: fix outer VLAN related macro Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 04/18] net/ice/base: add VLAN TPID for VLAN filters Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 05/18] net/ice/base: support checking double VLAN mode Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 06/18] net/ice/base: support configuring device in " Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 07/18] net/ice/base: do not set VLAN mode in DCF mode Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 08/18] net/ice/base: update boost TCAM for DVM Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 09/18] net/ice/base: change protocol ID for VLAN in DVM Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 10/18] net/ice/base: refactor post DDP download VLAN mode config Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 11/18] net/ice/base: log if DDP/FW do not support QinQ Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 12/18] net/ice/base: add ethertype offset for QinQ dummy packet Haiyue Wang
2021-06-11  6:58 ` [PATCH 20.11 v1 13/18] net/ice/base: add inner VLAN protocol type for QinQ filter Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 14/18] net/ice/base: fix QinQ PPPoE dummy packet selection Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 15/18] net/ice: fix VLAN strip for double VLAN Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 16/18] net/ice: fix VLAN 0 adding based on VLAN mode Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 17/18] net/ice: enable QinQ filter for switch Haiyue Wang
2021-06-11  6:58 ` [dpdk-stable] [PATCH 20.11 v1 18/18] net/ice: update QinQ switch filter handling Haiyue Wang
2021-06-11  7:15 ` [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN design for Intel ice PMD Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 01/18] net/ice/base: align add VSI and update VSI AQ command buffer Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 02/18] net/ice/base: add interface to support configuring VLAN mode Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 03/18] net/ice/base: fix outer VLAN related macro Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 04/18] net/ice/base: add VLAN TPID for VLAN filters Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 05/18] net/ice/base: support checking double VLAN mode Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 06/18] net/ice/base: support configuring device in " Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 07/18] net/ice/base: do not set VLAN mode in DCF mode Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 08/18] net/ice/base: update boost TCAM for DVM Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 09/18] net/ice/base: change protocol ID for VLAN in DVM Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 10/18] net/ice/base: refactor post DDP download VLAN mode config Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 11/18] net/ice/base: log if DDP/FW do not support QinQ Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 12/18] net/ice/base: add ethertype offset for QinQ dummy packet Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 13/18] net/ice/base: add inner VLAN protocol type for QinQ filter Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 14/18] net/ice/base: fix QinQ PPPoE dummy packet selection Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 15/18] net/ice: fix VLAN strip for double VLAN Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 16/18] net/ice: fix VLAN 0 adding based on VLAN mode Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 17/18] net/ice: enable QinQ filter for switch Haiyue Wang
2021-06-11  7:15   ` [dpdk-stable] [PATCH 20.11 v2 18/18] net/ice: update QinQ switch filter handling Haiyue Wang
2021-06-16 15:47   ` [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN design for Intel ice PMD Luca Boccassi
2021-06-17  1:16     ` Wang, Haiyue
2021-06-17  8:53       ` Xueming(Steven) Li
2021-06-17 10:04         ` Kevin Traynor
2021-06-18  3:22           ` Wang, Haiyue
2021-06-18 10:12             ` Kevin Traynor
2021-06-18 11:46               ` Wang, Haiyue
2021-06-21  8:28             ` Thomas Monjalon
2021-06-21  8:34               ` Wang, Haiyue
2021-06-21  8:59                 ` Kevin Traynor
2021-06-21 10:28               ` Kevin Traynor [this message]
2021-06-22  1:41                 ` Wang, Haiyue
2021-06-18  1:56         ` Wang, Haiyue
2021-06-20 13:47           ` Xueming(Steven) Li
2021-06-21  1:35             ` Wang, Haiyue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f368eff-3fc5-0d9f-7eab-95a731ac110d@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bluca@debian.org \
    --cc=christian.ehrhardt@canonical.com \
    --cc=haiyue.wang@intel.com \
    --cc=qi.fu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git