From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B3E0EA00E6 for ; Fri, 22 Mar 2019 18:17:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7CAB01B71D; Fri, 22 Mar 2019 18:17:37 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 128C61B6DC; Fri, 22 Mar 2019 18:17:30 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C95B308623D; Fri, 22 Mar 2019 17:17:29 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1081410018FF; Fri, 22 Mar 2019 17:17:23 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, ramirose@gmail.com, arybchenko@solarflare.com, ferruh.yigit@intel.com, stable@dpdk.org References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: <3f88ea40-fbc3-1ee7-ecef-5dc93ad4ff83@redhat.com> Date: Fri, 22 Mar 2019 18:17:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1553261824-1881-2-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 22 Mar 2019 17:17:29 +0000 (UTC) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 3/22/19 2:37 PM, David Marchand wrote: > Having the standard stats and the rx burst stats on the same line gives a > really long line and is not consistent with the rest. > > Before: > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > > After: > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > Fixes: af75078fece3 ("first public release") > Cc:stable@dpdk.org While the patch is good, I wonder whether we should backport it. Indeed, it might break some scripts parsing testpmd output. Any thoughts? > Signed-off-by: David Marchand > Reviewed-by: Rami Rosen > Reviewed-by: Andrew Rybchenko > --- > Changelog since v2: > - Cc'd stable > > ---