patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v3 1/2] net/ice: fix wrong RSS hash update
       [not found] <20210303075648.12399-1>
@ 2021-03-05  6:03 ` Wenjun Wu
  2021-03-24 11:50   ` Zhang, Qi Z
  2021-03-05  6:04 ` [dpdk-stable] [PATCH v3 2/2] net/iavf: " Wenjun Wu
  1 sibling, 1 reply; 4+ messages in thread
From: Wenjun Wu @ 2021-03-05  6:03 UTC (permalink / raw)
  To: dev, qiming.yang, qi.z.zhang; +Cc: Wenjun Wu, stable

This patch change judgment statements to disable RSS for pf
when users need to disable RSS or RSS hash function configured
is not supported.

Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config")
Cc: stable@dpdk.org

Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>

---
v2: do pf->rss_hf = 0 when rss_conf->rss_hf == 0 instead of direct
removal to avoid unnecessary judgment.
v3: fix the same issue for both pf and vf.
---
 drivers/net/ice/ice_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index f43b2e0b2..299162286 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -4461,8 +4461,10 @@ ice_rss_hash_update(struct rte_eth_dev *dev,
 	if (status)
 		return status;
 
-	if (rss_conf->rss_hf == 0)
+	if (rss_conf->rss_hf == 0) {
+		pf->rss_hf = 0;
 		return 0;
+	}
 
 	/* RSS hash configuration */
 	ice_rss_hash_set(pf, rss_conf->rss_hf);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-stable] [PATCH v3 2/2] net/iavf: fix wrong RSS hash update
       [not found] <20210303075648.12399-1>
  2021-03-05  6:03 ` [dpdk-stable] [PATCH v3 1/2] net/ice: fix wrong RSS hash update Wenjun Wu
@ 2021-03-05  6:04 ` Wenjun Wu
  2021-03-24 14:46   ` Ferruh Yigit
  1 sibling, 1 reply; 4+ messages in thread
From: Wenjun Wu @ 2021-03-05  6:04 UTC (permalink / raw)
  To: dev, jingjing.wu, beilei.xing; +Cc: Wenjun Wu, stable

This patch change judgment statements to disable RSS for vf
when users need to disable RSS or RSS hash function configured
is not supported.

Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS")
Cc: stable@dpdk.org

Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>

---
v3: fix the same issue for both pf and vf.
---
 drivers/net/iavf/iavf_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 4d3772202..d2d950aa6 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1250,8 +1250,10 @@ iavf_dev_rss_hash_update(struct rte_eth_dev *dev,
 	if (ret)
 		return ret;
 
-	if (rss_conf->rss_hf == 0)
+	if (rss_conf->rss_hf == 0) {
+		vf->rss_hf = 0;
 		return 0;
+	}
 
 	if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF) {
 		/* Clear existing RSS. */
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH v3 1/2] net/ice: fix wrong RSS hash update
  2021-03-05  6:03 ` [dpdk-stable] [PATCH v3 1/2] net/ice: fix wrong RSS hash update Wenjun Wu
@ 2021-03-24 11:50   ` Zhang, Qi Z
  0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2021-03-24 11:50 UTC (permalink / raw)
  To: Wu, Wenjun1, dev, Yang, Qiming; +Cc: stable



> -----Original Message-----
> From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Sent: Friday, March 5, 2021 2:03 PM
> To: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>; stable@dpdk.org
> Subject: [PATCH v3 1/2] net/ice: fix wrong RSS hash update
> 
> This patch change judgment statements to disable RSS for pf when users need
> to disable RSS or RSS hash function configured is not supported.
> 
> Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH v3 2/2] net/iavf: fix wrong RSS hash update
  2021-03-05  6:04 ` [dpdk-stable] [PATCH v3 2/2] net/iavf: " Wenjun Wu
@ 2021-03-24 14:46   ` Ferruh Yigit
  0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2021-03-24 14:46 UTC (permalink / raw)
  To: Wenjun Wu, dev, jingjing.wu, beilei.xing; +Cc: stable

On 3/5/2021 6:04 AM, Wenjun Wu wrote:
> This patch change judgment statements to disable RSS for vf
> when users need to disable RSS or RSS hash function configured
> is not supported.
> 
> Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> 

for record,
1/2 merged to next-net-intel, but there is v4 for iavf one and this version is 
not merged.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-24 14:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210303075648.12399-1>
2021-03-05  6:03 ` [dpdk-stable] [PATCH v3 1/2] net/ice: fix wrong RSS hash update Wenjun Wu
2021-03-24 11:50   ` Zhang, Qi Z
2021-03-05  6:04 ` [dpdk-stable] [PATCH v3 2/2] net/iavf: " Wenjun Wu
2021-03-24 14:46   ` Ferruh Yigit

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git