From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD6E543DEB for ; Wed, 3 Apr 2024 13:15:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE2A2402CE; Wed, 3 Apr 2024 13:15:37 +0200 (CEST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id A5A924025C for ; Wed, 3 Apr 2024 13:15:35 +0200 (CEST) Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-34391544c46so506065f8f.0 for ; Wed, 03 Apr 2024 04:15:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712142935; x=1712747735; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JJ8pTbRa8P2+PS77IbTrd/8beggCM4DGh6EjiHSSnyU=; b=wQcjLUfPyz20k9Sqo3KnY2JwjdSF0S22GashiXs96l4YQ30K1vdAlzFGaeijhaFidS zjHVj7CSyXJ58Sv6Q/3c+vJG1DJNpaKth7Kl5H+qWXBDUEhEQCb6C3ifS1Us4qh5+bY9 xQuUPpdGVLGw+tQW4BJGf1lX+ObR2M32lUH1VTBLYyBPFg4JG+zD09crHQrpGyNZ7fhE MDiLCwgJllR2aTUs0XLVBrVMoIZUaLVue0yR4hXQJSGyLrkU1+emwiEj10XYNWgfDZcD JoCf3+iirRTd87AhGwcHj3btd9eqrcy26ol+PUG9iMiq443Ds1MPaaKXdEKwYTySjLmq 2hpw== X-Gm-Message-State: AOJu0YzARVT1e8NRwlQDxqVj0Q3SE48ZHuDwwK1mlb88dpuulsFnOuY/ aCvsWgL/BE19IJc9IYwM4OXRMvRCQ6CM6gNC1vzxlvYwcQKbiagbBgbwVEzF0P8= X-Google-Smtp-Source: AGHT+IGQ0p6yl6G9R5gU5HY76bYphROZ9MHlRp2TlRW6R8PhlWbJWAANiRrCsiHUX8STsinUNSYEUQ== X-Received: by 2002:adf:a4c3:0:b0:33e:69db:bf9e with SMTP id h3-20020adfa4c3000000b0033e69dbbf9emr3753018wrb.67.1712142934938; Wed, 03 Apr 2024 04:15:34 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id i9-20020a0560001ac900b0033e41e1ad93sm16993786wry.57.2024.04.03.04.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 04:15:34 -0700 (PDT) Message-ID: <40040364d17a265bd46679864c990c87ff654122.camel@debian.org> Subject: Re: [PATCH 22.11] net/mlx5: fix async flow create error handling From: Luca Boccassi To: Dariusz Sosnowski , Matan Azrad , Viacheslav Ovsiienko , Suanming Mou Cc: stable@dpdk.org, Ori Kam Date: Wed, 03 Apr 2024 12:15:33 +0100 In-Reply-To: <20240403083805.23622-1-dsosnowski@nvidia.com> References: <20240403083805.23622-1-dsosnowski@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, 2024-04-03 at 10:38 +0200, Dariusz Sosnowski wrote: > [ upstream commit 5ecc8df4fad3411a53c20406f99b59dc736a6d1e ] >=20 > Whenever processing of asynchronous flow rule create operation failed, > but after some dynamic flow actions had already been allocated, > these actions were not freed during error handling flow. > That behavior lead to leaks e.g., RSS/QUEUE action objects were leaked > which triggered assertions during device cleanup. >=20 > This patch adds flow rule cleanup handling in case of an error > during async flow rule creation. >=20 > Fixes: 3a2f674b6aa8 ("net/mlx5: add queue and RSS HW steering action") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dariusz Sosnowski > Acked-by: Ori Kam >=20 This patch does not apply on stable/22.11, how was it tested? --=20 Kind regards, Luca Boccassi