From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 693FEA05D3 for ; Wed, 27 Mar 2019 10:39:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 501864F9A; Wed, 27 Mar 2019 10:39:15 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6F38E4F9A; Wed, 27 Mar 2019 10:39:10 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 05B1321C86; Wed, 27 Mar 2019 05:39:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 27 Mar 2019 05:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=d0/fYsd2YFjADddYlqCI2+exyvNvSSLQS4AzumZYqbM=; b=sf1ZN4rEr/MA 5Z4oWcX3vcYyH89+SPvA4bY87+LQi7LUBqpENhtGdLoWymMpnDnFAHDsEXJ5v9V0 p9JD+Zt27IHHTfD52BwmvSsL0UEs/+DaRfW5RUMl/wl6aF6JKUTT0CPjkB1Q5S3M aINWrcBYGydvutPK3nccLW69njM9Ifw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=d0/fYsd2YFjADddYlqCI2+exyvNvSSLQS4AzumZYq bM=; b=REzhrb7rn24TlBioGU1GsXChCPkclMUHwZh1Wa9W4nB0l1aWdM7Rkj+MQ McAlO7qXneQirqrsqqcCDEHemUEXnoikfbMVJIUzeLEga1Jgq8eQ86S5vhE+rBqP NU8w+h4IGerm+8qIFGYFquwW8RAmayi+crv5khXeJH/AEMDReN2/4VUJ0DOh3T01 mLnpKEKBa1C2YpnKbSqpdNHg/Ng+i/3CYp4OK7SDpSNyZClql0cQaqWZR1JmGJQ3 n4P6dMGWZhdYS4CQsRFB4QIvhNfKFiXXA1owbKZjJAV9g8soH9gCJRHyH/iKeiPd kb8I5s5hojv4rK1196oOymTGByI+Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedvgddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F82B10319; Wed, 27 Mar 2019 05:39:08 -0400 (EDT) From: Thomas Monjalon To: Andrius Sirvys Cc: dev@dpdk.org, Bruce Richardson , stable@dpdk.org Date: Wed, 27 Mar 2019 10:39:07 +0100 Message-ID: <4103365.eioPbUUbMs@xps> In-Reply-To: <20190311163141.GA805836@bricha3-MOBL.ger.corp.intel.com> References: <1552317491-161841-1-git-send-email-andrius.sirvys@intel.com> <20190311163141.GA805836@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] acl: fix missing flags when compiling without AVX2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 11/03/2019 17:31, Bruce Richardson: > On Mon, Mar 11, 2019 at 03:18:11PM +0000, Andrius Sirvys wrote: > > When compiling the ACL library on a system without AVX2 support, > > the flags used to compile the AVX2-specific code for later run-time > > use were not based on the regular cflags for the rest of the library. > > This can cause errors due to symbols being missed/undefined > > due to incorrect flags. For example, > > when testing compilation on Alpine linux, we got: > > error: unknown type name 'cpu_set_t' > > due to _GNU_SOURCE not being defined in the cflags. > > > > This issue can be fixed by appending "-mavx2" to > > the cflags rather than replacing them with it. > > > > Fixes: 5b9656b157d3 ("lib: build with meson") > > Cc: stable@dpdk.org > > > > Signed-off-by: Andrius Sirvys > > --- > > --- a/lib/librte_acl/meson.build > > +++ b/lib/librte_acl/meson.build > > - c_args: '-mavx2') > > + c_args: cflags + ['-mavx2']) > > Looks to be 2 spaces rather than 1 before the opening "[", but not a big > deal and can be fixed on apply if necessary. > > Acked-by: Bruce Richardson Applied (without double space), thanks