patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Wang, Haiyue" <haiyue.wang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"pvalerio@redhat.com" <pvalerio@redhat.com>,
	"aconole@redhat.com" <aconole@redhat.com>,
	"Rong, Leyi" <leyi.rong@intel.com>,
	"Tu, Lijuan" <lijuan.tu@intel.com>,
	"Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>,
	"Feifei.Wang2@arm.com" <Feifei.Wang2@arm.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Guo, Jia" <jia.guo@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-stable] [PATCH v2] net/ixgbe: fix UDP zero checksum error
Date: Thu, 4 Feb 2021 07:45:18 +0000
Message-ID: <418519d5c5b44f09a0ac27bf155f91b5@intel.com> (raw)
In-Reply-To: <CAJFAV8witkHXngSJayQODY99zUYJqnji61LqHsonb34wiiP02Q@mail.gmail.com>



> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, February 3, 2021 4:32 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org;
> pvalerio@redhat.com; aconole@redhat.com; Rong, Leyi
> <leyi.rong@intel.com>; Tu, Lijuan <lijuan.tu@intel.com>;
> Ruifeng.Wang@arm.com; Feifei.Wang2@arm.com; stable@dpdk.org; Guo, Jia
> <jia.guo@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Subject: Re: [PATCH v2] net/ixgbe: fix UDP zero checksum error
> 
> On Wed, Feb 3, 2021 at 9:07 AM Zhang, Qi Z <qi.z.zhang@intel.com> wrote:
> > > -----Original Message-----
> > > From: Wang, Haiyue <haiyue.wang@intel.com>
> > > Sent: Wednesday, February 3, 2021 10:19 AM
> > > To: dev@dpdk.org
> > > Cc: pvalerio@redhat.com; aconole@redhat.com;
> > > david.marchand@redhat.com; Zhang, Qi Z <qi.z.zhang@intel.com>; Rong,
> > > Leyi <leyi.rong@intel.com>; Tu, Lijuan <lijuan.tu@intel.com>;
> > > Ruifeng.Wang@arm.com; Feifei.Wang2@arm.com; Wang, Haiyue
> > > <haiyue.wang@intel.com>; stable@dpdk.org; Guo, Jia
> > > <jia.guo@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>;
> > > Ananyev, Konstantin <konstantin.ananyev@intel.com>
> > > Subject: [PATCH v2] net/ixgbe: fix UDP zero checksum error
> > >
> > > There is an 82599 errata that UDP frames with a zero checksum are
> > > incorrectly marked as checksum invalid by the hardware.  This was
> > > leading to misleading PKT_RX_L4_CKSUM_BAD flag.
> > >
> > > This patch changes the bad UDP checksum to
> PKT_RX_L4_CKSUM_UNKNOWN,
> > > so the software application will then have to recompute the checksum
> > > itself if needed.
> > >
> > > Bugzilla ID: 629
> > >
> > > Fixes: af75078fece3 ("first public release")
> > > Cc: stable@dpdk.org
> > >
> > > Reported-by: Paolo Valerio <pvalerio@redhat.com>
> > > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> >
> > Applied to dpdk-next-net-intel.
> 
> Why the rush for applying?
> The ARM part is not done, Paolo said he would test the patch and I am pretty
> sure a review can't hurt.
> 
> 
> --
> David Marchand

Oops, it should be a mistake, the patch has not been acked and reviewed yet.

Thanks for capture, will revert.
Qi


  reply	other threads:[~2021-02-04  7:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02  7:06 [dpdk-stable] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum Haiyue Wang
2021-02-02  9:45 ` David Marchand
2021-02-02 12:42   ` Wang, Haiyue
2021-02-02 12:53     ` David Marchand
2021-02-02 12:56       ` Wang, Haiyue
2021-02-02 14:28         ` Wang, Haiyue
2021-02-02 17:42           ` Paolo Valerio
2021-02-02 12:54   ` Wang, Haiyue
2021-02-03  2:19 ` [dpdk-stable] [PATCH v2] net/ixgbe: fix UDP zero checksum error Haiyue Wang
2021-02-03  8:07   ` Zhang, Qi Z
2021-02-03  8:32     ` David Marchand
2021-02-04  7:45       ` Zhang, Qi Z [this message]
2021-02-04 14:39 ` [dpdk-stable] [PATCH v3] " Haiyue Wang
2021-02-05 17:50   ` Paolo Valerio
2021-02-07 18:40   ` Paolo Valerio
2021-02-08 13:48   ` Ananyev, Konstantin
2021-02-09  1:23     ` Zhang, Qi Z
2021-02-25 10:54   ` David Marchand
2021-04-07 11:53     ` David Marchand
2021-04-08  1:12       ` Wang, Haiyue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=418519d5c5b44f09a0ac27bf155f91b5@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=Feifei.Wang2@arm.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=jia.guo@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=leyi.rong@intel.com \
    --cc=lijuan.tu@intel.com \
    --cc=pvalerio@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git