From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4B3B31B273; Mon, 7 Jan 2019 18:03:34 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DC04B2206F; Mon, 7 Jan 2019 12:03:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 07 Jan 2019 12:03:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=r6ixnTwYgjEUlMDP/3tCx4BBDiYbB+SNhgbSjn73EvQ=; b=QaIs2fKUQH8N Ax23FxZIw5SqIeWKKscgA17E4x1l/0lFTbKjIkODjNC9/vBYmh2Tza6yDM/TOw3C BKIFladcPDhSd/46yS2gAD4nmzMCjdsUHTt2I6tietG5UfMlIYB9Wq0rOliaXzkI +YTba2aQjDPHufZ9pfbdJBi4oJQnYnE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=r6ixnTwYgjEUlMDP/3tCx4BBDiYbB+SNhgbSjn73E vQ=; b=nKsMvrW7Sud7thT3tc5SX8h2Pf2qXi6AqWqgrGHKI40a++w/lEFtz5EIT e8ci4e9Jy46m1M+oQNssKhFSTHiw48eEP5NktO7IoOyEJSU0neeHHHoEXwJspnS8 B28UXcZlnAwLSVMS+OrlmZr1RBRJDMGjjth4/fJachohuRYZybsd5YjS+9i16XKT g88yCYuUY9lRCbiv5RJXd1Wo4tQyli7ybeBWQZnLXThfvsCrkYUuVq5qooUN7qAk 9Dq7JWtiDVctv7Gie4xgu5XIcDV6AwR51trneEB+9s1x4WbHdTYXo9xLB97Ad6u/ gt/bfoYxRy/k/XnDllirGrsWuFHJg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrvdejgdelheculddtuddrgedtkedrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeejrddufeegrddvtdefrddukeeg necurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvg htnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E3FA1E453B; Mon, 7 Jan 2019 12:03:31 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: techboard@dpdk.org, Luca Boccassi , dev@dpdk.org, stable@dpdk.org Date: Mon, 07 Jan 2019 18:03:30 +0100 Message-ID: <4262310.sn7WroDi98@xps> In-Reply-To: <20190107165552.GA23828@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <1546879174.6022.24.camel@debian.org> <20190107165552.GA23828@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-techboard] [PATCH 2/2] build: use dependency() instead of find_library() X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 17:03:34 -0000 07/01/2019 17:55, Bruce Richardson: > On Mon, Jan 07, 2019 at 04:39:34PM +0000, Luca Boccassi wrote: > > On Mon, 2019-01-07 at 14:28 +0000, Bruce Richardson wrote: > > > However, in > > > conjunction with meson version checks, I believe this was done this > > > way > > > originally because of a meson bug which caused recursive dependencies > > > for > > > things like this to get duplicated many times in the build.ninja > > > file. > > > > > > https://github.com/mesonbuild/meson/issues/2150 > > > > > > If we take the approach of adding bsd explicitly using dependency > > > object > > > our minimum version needs to have the fix for this bug included. > > > > Ah that's not nice. Just verified, and it happens with dependency() as > > well as find_library(). It was fixed in 0.47.1. > > > > Yep, it was a right royal pain when I was doing the original work. Now that > there is a fix in, we can do cleanups like you suggest if we are prepared > to bump our minimum version. > > I'll refer back to the key question here: > "Is it reasonable to ask users compiling DPDK to pull meson from pip rather > than using the distro built-in version?" > [Adding techboard on CC, in the hopes they might have some thoughts] > > If it is ok for most folks, and personally I don't think it's a big deal, > then that gives us a faster path forward. If not, we raise the minimum more > slowly, and keep the existing way of managing the dependencies for a while > longer. Worst case, I'd still hope by 19.11 LTS for us to have minimum > 0.47.1 to have the fix in question. Please, could you describe what are the meson versions in major distros?