patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Hunt <david.hunt@intel.com>
To: Richael Zhuang <richael.zhuang@arm.com>, dev@dpdk.org
Cc: yux.jiang@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v4 2/2] test/power: round cpuinfo cur freq only when using CPPC cpufreq
Date: Wed, 23 Jun 2021 15:13:19 +0100	[thread overview]
Message-ID: <42a2e45b-2b06-debb-92e8-f95a8356f8a3@intel.com> (raw)
In-Reply-To: <20210623035541.50543-3-richael.zhuang@arm.com>

Hi Richael,

On 23/6/2021 4:55 AM, Richael Zhuang wrote:
> On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not
> be exactly the same as what was set when using CPPC cpufreq driver.
> For other cpufreq driver, no need to round it currently, or else
> this check will fail with turbo enabled. For example, with acpi_cpufreq,
> cpuinfo_cur_freq can be 2401000 which is equal to freqs[0].It should
> not be rounded to 2400000.
>
> Fixes: 606a234c6d360 ("test/power: round CPU frequency to check")
> Cc: richael.zhuang@arm.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
> ---
>   app/test/test_power_cpufreq.c | 23 ++++++++++++++---------
>   1 file changed, 14 insertions(+), 9 deletions(-)

--snip--

Makes sense.

Reviewed-by: David Hunt <david.hunt@intel.com>




      reply	other threads:[~2021-06-23 14:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210512035709.37755-2-richael.zhuang@arm.com>
     [not found] ` <20210623035541.50543-1-richael.zhuang@arm.com>
2021-06-23  3:55   ` Richael Zhuang
2021-06-23 14:13     ` David Hunt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42a2e45b-2b06-debb-92e8-f95a8356f8a3@intel.com \
    --to=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=richael.zhuang@arm.com \
    --cc=stable@dpdk.org \
    --cc=yux.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).