From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 81825A0A03
for <public@inbox.dpdk.org>; Mon, 18 Jan 2021 15:48:25 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 6B7D6140EFA;
Mon, 18 Jan 2021 15:48:25 +0100 (CET)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by mails.dpdk.org (Postfix) with ESMTP id 396B8140EEE;
Mon, 18 Jan 2021 15:48:21 +0100 (CET)
IronPort-SDR: z6s3skff4VmOkPCmlJjWfbBVvDzZ6ZxCFfK8C+eJ+N6ADSmQRMpkVTQtM7JE6eOmZ0Q+nDYvUK
7PSg8clWELjA==
X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="157991487"
X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="157991487"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
18 Jan 2021 06:48:15 -0800
IronPort-SDR: luX96wPOfb3p1dxwOsF28XxAdNjk4lomYv543BdjsfmGOJYR311wH/JnyKrZvt50MTLoZgVpxM
44x/6x+j/qWA==
X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="383595262"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.24])
([10.213.241.24])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
18 Jan 2021 06:48:13 -0800
To: Thomas Monjalon <thomas@monjalon.net>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Wiles, Keith" <keith.wiles@intel.com>, "Power, Ciara"
<ciara.power@intel.com>
References: <20210114121733.46801-1-bruce.richardson@intel.com>
<MN2PR11MB382147086D8A149185F6EF27E6A80@MN2PR11MB3821.namprd11.prod.outlook.com>
<38646937.bSsQRFMa1O@thomas>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <42af2feb-2066-f87f-4246-a82285ed7e21@intel.com>
Date: Mon, 18 Jan 2021 14:48:10 +0000
MIME-Version: 1.0
In-Reply-To: <38646937.bSsQRFMa1O@thomas>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: avoid blocking
telemetry callback for link status
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On 1/18/2021 2:02 PM, Thomas Monjalon wrote:
>>> When querying the link status via telemetry interface, we don't want the
>>> client to have to wait for multiple seconds for a reply. Therefore use
>>> "rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the telemetry
>>> callback.
>>>
>>> Cc: stable@dpdk.org
>>> Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks")
>>>
>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>> ---
>>> --- a/lib/librte_ethdev/rte_ethdev.c
>>> +++ b/lib/librte_ethdev/rte_ethdev.c
>>> @@ -5692,7 +5692,7 @@ eth_dev_handle_port_link_status(const char *cmd
>>> - ret = rte_eth_link_get(port_id, &link);
>>> + ret = rte_eth_link_get_nowait(port_id, &link);
>>
>> This change looks good to me.
>>
>> Acked-by: Ciara Power <ciara.power@intel.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
Applied to dpdk-next-net/main, thanks.