From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Baum <michaelba@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org, Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-stable] [PATCH 2/2] net/mlx5: fix Tx queue creation error flow
Date: Wed, 06 Jan 2021 22:47:16 +0100 [thread overview]
Message-ID: <4387862.qzZCY7BrVk@thomas> (raw)
In-Reply-To: <1608022112-13036-2-git-send-email-michaelba@nvidia.com>
15/12/2020 09:48, Michael Baum:
> In Tx queue creation, there are two validations for the Tx
> configuration.
>
> When one of them fails, the MR btree memory was not freed what caused a
> memory leak.
>
> Free it.
>
> Fixes: f6d9ab4e769f ("net/mlx5: check Tx queue size overflow")
> Cc: stable@dpdk.org
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
It is not really fixing the queue creation but a leak.
In such case, it is more explicit to say in title:
"fix leak on [...] failure"
Series applied in next-net-mlx with above wording, thanks.
prev parent reply other threads:[~2021-01-06 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 8:48 [dpdk-stable] [PATCH 1/2] net/mlx5: fix Rx " Michael Baum
2020-12-15 8:48 ` [dpdk-stable] [PATCH 2/2] net/mlx5: fix Tx " Michael Baum
2021-01-06 21:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4387862.qzZCY7BrVk@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).