From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3496A0528 for ; Mon, 20 Jan 2020 11:08:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0AF93576; Mon, 20 Jan 2020 11:08:56 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 393C62BF5; Mon, 20 Jan 2020 11:08:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9386321AD0; Mon, 20 Jan 2020 05:08:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 20 Jan 2020 05:08:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=yFaT5enHF7JrO8vn1kbUlfDMSydcx8sP23QfpxDW4s0=; b=Fq/JUHeTT8Tm H5kSLQibhUjdHzqo37o2ezNQPDpoHaMokh4kYVen1MCqwmF8VOkj64J9RiD211e7 JHBWkI7iwTqdjgjqOKERWCsUHrnFDkI8YM1DPnHrJFVMnVVu5cALIGrqVd3riiJ2 UqowF0hA5rcyUVNjfgc/zs8ugYmHMAE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=yFaT5enHF7JrO8vn1kbUlfDMSydcx8sP23QfpxDW4 s0=; b=Ks9faomFNWiKrzKePFqU+0WIjbdM+41Tu8ISNcZzN8ktx9fBk9PRfFuDb b4vROiQV4qTmbZAdG4tJZXWG3IHACcXqoclNSC4+6T4DoX+qnCdjmav6yeMcuPrk SueO+M0cRF2EDLIyHSnQbHlOTOj/ruvd5/2vxzvjgWv5oKbW2QpTZLxItbvuex1a GXWqIptx/YfVOnWEslm6rioJ+y1JjMhoHA8LWbKAtm1vccM2EKvD3AqKT5aI+USn fXp20XD2maGvYuYOpU0Ml4wqt4Rt+YqisUWwxE/Uv2Hgu9QzOn8do/AYvtGwi1Di uBH18RLQqlXXMYyL8LCyhl5PX3dlQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudehgddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2436D30607B4; Mon, 20 Jan 2020 05:08:51 -0500 (EST) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, Andrew Rybchenko , stable@dpdk.org Date: Mon, 20 Jan 2020 11:08:49 +0100 Message-ID: <4388597.neEnAmRlxL@xps> In-Reply-To: <20200117143429.10120-1-olivier.matz@6wind.com> References: <20200117143429.10120-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] mempool: fix anonymous populate X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 17/01/2020 15:34, Olivier Matz: > The documentation says that a negative errno is returned on error, but > in most places that's not the case. > > Fix the documentation and the exceptions in code. The second one > (return from populate_virt) also fixes a memory leak. > > Note that testpmd was using the function correctly. > > Fixes: aa10457eb4c2 ("mempool: make mempool populate and free api public") > Fixes: 6780f72fb82f ("mempool: populate with anonymous memory") > Fixes: 66e7ba0bad4c ("mempool: ensure mempool is initialized before populating") > Cc: stable@dpdk.org > > Signed-off-by: Olivier Matz Applied, thanks