From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id C2400A0353
for <public@inbox.dpdk.org>; Tue, 5 Nov 2019 11:11:09 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 914D52C37;
Tue, 5 Nov 2019 11:11:09 +0100 (CET)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E02D811A4;
Tue, 5 Nov 2019 11:11:05 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 6DA522208E;
Tue, 5 Nov 2019 05:11:05 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Tue, 05 Nov 2019 05:11:05 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=sH0MJh5de5zKaTrzmsQwCaPEFqa/COmzV/KqNZHCVzk=; b=KuwTfdtHRc6R
zxXs7yDJxAabvNsBWhxGvIhtas1Icfi82/gYRABE9XaTSSJkcOJHDsLGPSiqN5JA
+EsShxC/NCZ2r7C0Zx+RfQRBSJ74oMDtlPR9AgubZ6s027ldQUijrG2lqyqollLC
0/N8sJ85/n6JMQlvMDH/6nEEtMcalmw=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=sH0MJh5de5zKaTrzmsQwCaPEFqa/COmzV/KqNZHCV
zk=; b=g6ozvVWWKvXYy2uZ3lXLY4HydO1u3oixzdYcsWmf0HIKunGc+xMpObcVT
Y9SyBn+urFoLSVkKysKl9xyEeyujVuBJhOylWDDORCA283o0WXUvSuChaMQlUdFp
s1n2f3PDd6zOo4ELHXkvioqLqmxrsULyy12qhBpZ8keMnNzEiWAy8fdxJ8y2IGMa
0d/s5UZwOVo03lm2RR/MrSzV2Pkd87xNZIqy0vOwogMm6uE7q6ha0NtHyNztyAWM
/iqu1awUqj5MlGIbaVSJ7RAWC1BZCpXzjqQNP0iROH15dFGAkKCthGBSo4ayTBIK
NniA9UIp1PpjWFAYZ6SwwTG56HKjg==
X-ME-Sender: <xms:uErBXakVmEVhntXSZ7p-GlY6eRCGFqvmuS8vczh6j0j7wYwWwCPKOg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudduhedgudefucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf
hppeelfedrvdefrddutdegrddtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr
shesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:uErBXcQcnJQiIcqvUUjETNEqPtRY-2OMy7TKaEu2B_wQ1hFcyOhwjQ>
<xmx:uErBXQLWalduYqHlYfuf8iVM4zjqqUvMR1qV1a8dEM1dMCDe8n8EEQ>
<xmx:uErBXWEMi7eaNYEiXtPtp0_7czEe-KApyrBOWQswBBTljiJxjZ6MHQ>
<xmx:uUrBXVOZIKNTgSUunU52BaPw98xyZtrcfBXwgHk9u7ncs0MT-qSHfA>
Received: from xps.localnet (0.104.23.93.rev.sfr.net [93.23.104.0])
by mail.messagingengine.com (Postfix) with ESMTPA id B26723060061;
Tue, 5 Nov 2019 05:11:02 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Xiaoyu Min <jackmin@mellanox.com>
Cc: dev@dpdk.org, orika@mellanox.com, viacheslavo@mellanox.com,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>, stable@dpdk.org
Date: Tue, 05 Nov 2019 11:11:00 +0100
Message-ID: <4507833.CEzoxxxZIU@xps>
In-Reply-To: <1580ef9551619fbe0a1f85590cebaf4b026f7f0b.1572944613.git.jackmin@mellanox.com>
References: <1580ef9551619fbe0a1f85590cebaf4b026f7f0b.1572944613.git.jackmin@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: expand RSS flows based
on last item spec
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
Hi Jack,
If it is a fix, please change your title.
05/11/2019 10:16, Xiaoyu Min:
> When rte_flow_expand_rss expands rte_flow item list based on the RSS
> types.
There is no verb in this sentence.
> In another word, it will add some rte_flow items if the user
What is "it"?
> specified items are not complete, for example:
>
> ... pattern eth / end actions rss type tcp end ...
Please explain why it is not complete.
>
> above flow will be expaned to:
>
> ... pattern eth / end actions rss types tcp
> ... pattern eth / ipv4 / tcp / end actions rss types tcp ...
> ... pattern eth / ipv6 / tcp / end actsion rss types tcp ...
There are several typos in this text. Please check.
> However the expansion is just simply expanding items without
> checking last items' spec, means the expanded rules could have conflicting
> settings which is not reasonable and leads to some HW error, for
> example:
This wording is really not clear.
Please make short sentences.
> ... pattern eth type is 0x86DD / end actions rss types tcp ...
>
> is expaneded to:
>
> ... pattern eth type is 0x86DD / ipv4 / tcp end ...
>
> which has conflicting values: 0x86DD vs. ipv4 and HW will refuse create
> flow on some NICs.
>
> This patch will fix above by checking the last item's spec and try to
> complete the item list.
>
> Currently only support to complete item list based on L2/L3 layer.
>
> Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows")
> Cc: stable@dpdk.org
Missing empty line here to separate blocks.
> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
> ---
> lib/librte_ethdev/rte_flow.c | 132 +++++++++++++++++++++++++++++++++--
> 1 file changed, 127 insertions(+), 5 deletions(-)
It's a big change. It needs to be carefully reviewed.