From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 79AF9A0679 for ; Fri, 5 Apr 2019 15:14:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 664EB1B4E8; Fri, 5 Apr 2019 15:14:13 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8681B1B4E8 for ; Fri, 5 Apr 2019 15:14:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2224C23111; Fri, 5 Apr 2019 09:14:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 05 Apr 2019 09:14:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=tuulSF5LTgfZUDNCwnW2AJgxsOYmDcJWKeYrOo9d2CU=; b=ZYNe7T0QNKZ4 wszg/LIhs1OjJubW5aZCuca0Bw8ODHCdGIqzZDa1LqDHvgM0+gUqRttBi78YOGga uqhk8iMa5FLjV0ppvdSR8SHILJpDBbWjk9n5lX/UUdKTDshQx4dvmHp5KIQMXD3I zzyFm083xxlb5y6nF9X3Fj6xjO1Vb90= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=tuulSF5LTgfZUDNCwnW2AJgxsOYmDcJWKeYrOo9d2 CU=; b=1ILjlEF87u19Fv/KGVezBH1pIHaCGu2kjFVOjD2WUvwd9e8BVnxYXrmhz h7m+4Oqd00Lxc3KT+b30bXXX7Z7nNjGSgpoyTp284rTvyeEovpDrj+obCtNCT01x Ip1d5eJeplCYUgmEK05q1DonI/5xgqzD2lko94O75QGb2Ns2bSR6f+pghV/hLnE/ kmFOmyVNdXRJKfRru2lIYbEG1K/mA4T2Rq59a+AZ68JEgmLDfxQB+8yr+YY3hhgT PJM7C+Pa5JNrHKDIUD8DxN+WrgaNpABmgfDoCxKBZ7+mY8iiwaxCm7cWTSYnRu6W 1IvOKSxrR88N3N5IwmWQQKupwDmrA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdejgdehkeculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2CAC610380; Fri, 5 Apr 2019 09:14:11 -0400 (EDT) From: Thomas Monjalon To: Harman Kalra Cc: stable@dpdk.org, jerinj@marvell.com Date: Fri, 05 Apr 2019 15:14:09 +0200 Message-ID: <4534168.qckUeH1snz@xps> In-Reply-To: <1551434386-31464-1-git-send-email-hkalra@marvell.com> References: <1551434386-31464-1-git-send-email-hkalra@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH v2 1/2] metrics: new API to deinitialise metrics library X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 01/03/2019 11:00, Harman Kalra: > Once the library usage is over, it must be deinitialized which > will free the shared memory reserved during initialization. > > Fixes: observed an issue while running 'metrics_autotest' > continuously without quiting. For the first run 'metrics_autotest' > passes all test cases but second run onwards first test case > fails because metrics library is already initialized during > first run. > Cc: stable@dpdk.org > > Signed-off-by: Harman Kalra I was waiting for an ack on this patch, and realized that there was one already on v1. When sending v2, you should have reported the Ack. And to ease review between versions, please keep all the versions in the same thread with --in-reply-to. Would be nice if old contributors from Marvell would guide you. Thanks > --- > v2: > * Adding stable@dpdk.org into cc as this patch falls between bug fix > and new feature. I would vote for not backporting this new API. Any other opinion?