From: Thomas Monjalon <thomas@monjalon.net>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org, rasland@nvidia.com,
matan@nvidia.com, suanmingm@nvidia.com
Subject: Re: [PATCH v2] net/mlx5: fix hypervisor detection in VLAN workaround
Date: Thu, 12 Dec 2024 11:52:51 +0100 [thread overview]
Message-ID: <4686294.VLH7GnMWUR@thomas> (raw)
In-Reply-To: <20241206142605.2582139-1-viacheslavo@nvidia.com>
06/12/2024 15:26, Viacheslav Ovsiienko:
> The mlx5 PMD provides a specific workaround for the VMware ESXi
> hypervisor, enabling on-demand routing configuration to virtual
> machines. This workaround activates when the device type is
> a Virtual Function and either an ESXi hypervisor is detected
> or the hypervisor type is unknown.
>
> For non-x86 architectures the function rte_hypervisor_get()
> consistently returns an unknown type, which triggers the workaround
> automatically without any actual needs. If there are VLAN support
> requirements, this can lead to failures in inserting default control
> flows.
>
> Do not trigger the workaround for unknown hypervisor type
> in non-x86 environments.
It would be a lot better to fix rte_hypervisor_get().
I suggest starting with the read of /sys/class/dmi/id/
next prev parent reply other threads:[~2024-12-12 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 16:22 [PATCH] " Viacheslav Ovsiienko
2024-12-03 17:00 ` Stephen Hemminger
2024-12-06 14:26 ` [PATCH v2] " Viacheslav Ovsiienko
2024-12-12 10:52 ` Thomas Monjalon [this message]
2024-12-12 17:27 ` Stephen Hemminger
2024-12-13 7:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4686294.VLH7GnMWUR@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).