From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00C3645E84 for ; Thu, 12 Dec 2024 11:52:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8E4A402F0; Thu, 12 Dec 2024 11:52:57 +0100 (CET) Received: from fout-a3-smtp.messagingengine.com (fout-a3-smtp.messagingengine.com [103.168.172.146]) by mails.dpdk.org (Postfix) with ESMTP id 7A0D440269; Thu, 12 Dec 2024 11:52:55 +0100 (CET) Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfout.phl.internal (Postfix) with ESMTP id D87D61383706; Thu, 12 Dec 2024 05:52:54 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Thu, 12 Dec 2024 05:52:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1734000774; x=1734087174; bh=eguRhDSScq/DUO7XO+dHFKrN0O5UGiQSDyv4fbELLsc=; b= WzCkUg9Twkb1FwXoLIlhUu06dtPBZ5ss2JQ7zoZfhArW759wPZrlMetZPxIuX1dC tHoCZeKYA6CAbkuGezZwAGPeR9ZKYDyBT/OyWyTpKKWQeJ9v3M+bVDOSL78BWp6i I4r5H75GeZTe8bAz8J4vZBqsIWwmcEilJuRN0DT1pvcNICqfZYOCZ+0M16frHIHC tR2uKAwPq93dSO6VBiOU59SDFvKvnyldT5ur3oknhgMQYiBf4jf4VOjdAtZyAW9f Ws3iqG/k8pmTiedVpmJvh5Z8sbMjAHdmrveA4MPcxD+Rgko8clHOeUKnHAHrfDhj mcUyzSmd3uNapXgkVTQU7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1734000774; x= 1734087174; bh=eguRhDSScq/DUO7XO+dHFKrN0O5UGiQSDyv4fbELLsc=; b=K wBPgQIphgYVbjTYrmyGSHMKHuKzHCGkLHHNk9NzqExcEyBDa0FtsltrnqtTNwWas OxhaD6uMx+7F3XhzN8WNFuMCi2qdZrQZGMvMMUbVzyz3uYYZHkVhoLF+K5Lve+L0 Hc3J3NsWqKThTfLfnefRwcBS8h8+BKj//wbaDHa2rffAma7VUTrVVGBYKOUyXkwe mIDCGUHl98weGCG7gvAf989a7Efu0QIRKFMpnGGc90DVdyFcIRN+bp4QyK2Wy8SJ KW3kr8FP5VIopLgBIT10rZslzSZ79B3meDoqyQPpiHuVfytV1l0RbzQKT218haEL 38BkL9LzHWrThzzO2Ohkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrkeehgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeu veejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohepiedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepvhhirggthh gvshhlrghvohesnhhvihguihgrrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdho rhhgpdhrtghpthhtohepshhtrggslhgvseguphgukhdrohhrghdprhgtphhtthhopehrrg hslhgrnhgusehnvhhiughirgdrtghomhdprhgtphhtthhopehmrghtrghnsehnvhhiughi rgdrtghomhdprhgtphhtthhopehsuhgrnhhmihhnghhmsehnvhhiughirgdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Dec 2024 05:52:53 -0500 (EST) From: Thomas Monjalon To: Viacheslav Ovsiienko Cc: dev@dpdk.org, stable@dpdk.org, rasland@nvidia.com, matan@nvidia.com, suanmingm@nvidia.com Subject: Re: [PATCH v2] net/mlx5: fix hypervisor detection in VLAN workaround Date: Thu, 12 Dec 2024 11:52:51 +0100 Message-ID: <4686294.VLH7GnMWUR@thomas> In-Reply-To: <20241206142605.2582139-1-viacheslavo@nvidia.com> References: <20241203162200.2543986-1-viacheslavo@nvidia.com> <20241206142605.2582139-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 06/12/2024 15:26, Viacheslav Ovsiienko: > The mlx5 PMD provides a specific workaround for the VMware ESXi > hypervisor, enabling on-demand routing configuration to virtual > machines. This workaround activates when the device type is > a Virtual Function and either an ESXi hypervisor is detected > or the hypervisor type is unknown. > > For non-x86 architectures the function rte_hypervisor_get() > consistently returns an unknown type, which triggers the workaround > automatically without any actual needs. If there are VLAN support > requirements, this can lead to failures in inserting default control > flows. > > Do not trigger the workaround for unknown hypervisor type > in non-x86 environments. It would be a lot better to fix rte_hypervisor_get(). I suggest starting with the read of /sys/class/dmi/id/