From: "Doherty, Declan" <declan.doherty@intel.com>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>, dev@dpdk.org
Cc: gakhil@marvell.com, fiona.trahe@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] crypto/qat: fix to small sgl oop min offset
Date: Wed, 14 Apr 2021 09:51:09 +0100 [thread overview]
Message-ID: <4705db37-2c89-b68a-d36f-e14a3216dfd9@intel.com> (raw)
In-Reply-To: <20210318131617.24660-1-arkadiuszx.kusztal@intel.com>
On 18/03/2021 1:16 PM, Arek Kusztal wrote:
> This commit fixes problem with to small offset when both offsets
> (auth, cipher) are non zero in digest encrypt case,
> when using out-of-place and sgl.
>
> Fixes: 40002f6c2a24 ("crypto/qat: extend support for digest-encrypted auth-cipher")
> Cc: stable@dpdk.org
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> drivers/crypto/qat/qat_sym.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
> index 4b7676deb..a6cd33be3 100644
> --- a/drivers/crypto/qat/qat_sym.c
> +++ b/drivers/crypto/qat/qat_sym.c
> @@ -162,6 +162,7 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,
> uint8_t do_sgl = 0;
> uint8_t in_place = 1;
> int alignment_adjustment = 0;
> + int oop_shift = 0;
> struct rte_crypto_op *op = (struct rte_crypto_op *)in_op;
> struct qat_sym_op_cookie *cookie =
> (struct qat_sym_op_cookie *)op_cookie;
> @@ -472,6 +473,7 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,
> rte_pktmbuf_iova_offset(op->sym->m_src, min_ofs);
> dst_buf_start =
> rte_pktmbuf_iova_offset(op->sym->m_dst, min_ofs);
> + oop_shift = min_ofs;
>
> } else {
> /* In-place operation
> @@ -532,7 +534,7 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,
> /* First find the end of the data */
> if (do_sgl) {
> uint32_t remaining_off = auth_param->auth_off +
> - auth_param->auth_len + alignment_adjustment;
> + auth_param->auth_len + alignment_adjustment + oop_shift;
> struct rte_mbuf *sgl_buf =
> (in_place ?
> op->sym->m_src : op->sym->m_dst);
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2021-04-14 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 13:16 Arek Kusztal
2021-04-14 8:51 ` Doherty, Declan [this message]
2021-04-14 19:29 ` [dpdk-stable] [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4705db37-2c89-b68a-d36f-e14a3216dfd9@intel.com \
--to=declan.doherty@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=gakhil@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).