From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7202B42B73 for ; Mon, 22 May 2023 17:37:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AC6242670; Mon, 22 May 2023 17:37:22 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 43C6540EE5; Mon, 22 May 2023 17:37:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684769839; x=1716305839; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=UAzhWTpsVT/oyj/+V3n7Vl8qh2Sb/QkgLHH+lZV9bC8=; b=PiC0rnkEbeX3rC+XzRKiCyTkycQwOZolOx5+BvAQfX+63FDA9XVQDr3Z LklIwRl3Wc6rJZmYhUrwzkQaPuwYD8ALP2oiY25FA8eckn0lZx70II2NT 2vGY5HLTreeShfHGttKRL/vgeeLe9r8KTIKlpC/vZGKDNdPfC3z+qfPeu O0N6LdDSNfUsb8z0NU66naB9mIceK/LvS5/FE9wHHYzzNJDPSf5lyikCf a3EFT3+cteUp2WzpEgrbSoLPENgICI0ETRgZObx29qcV0yT9mMBHl2xiO P372suPBslGx0zXW18rCHoVz8RT6xn7SGRJFDnQ+NnTmJeQm3AmmybrE9 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="352976669" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="352976669" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 08:37:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="768573234" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="768573234" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 22 May 2023 08:37:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 22 May 2023 08:37:17 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 22 May 2023 08:37:17 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 22 May 2023 08:37:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cysHo3YtE9ogiRyYDbNSAWvJfWheyNDmS2eVOrOQf4rMwKcg6CAz4xuNglQUvnmoh+YQ8r2ZTQfkJvtJ/RskeXGeCciISe/PxV4JarAbmeFJh4zMN0VYzuK2LmEEjjdxfcOxmr0s8OTKCknPdk3QIHnNXnaHuob3O8KzNqu6jgU/JCPaxTCmOdewEyd54n4h+BoBxzGJkWdoRg626tuaDD/mZsssZJuf+DgVP6eXvz4pHZx4Kdpsbzwbo2kCnPjkoTRPq4Kvn8CZi2BqJ0zjMcmyyPt6UZZ7XwKLd60ew/oSRkHMNgOeSTgaoO2KZB7ZRQ8vcgC1+WVfn1W9zQ3EAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ff/z88X7jJfNeayzG2vTL5WbljqUl7RK/eCLUvITTOw=; b=g7OMqkJ6tpT7CHNXXGJ8UCkK7hd5elDh8ypeD+SfOZyRNsGs0L3OPk2C+3XD4d5agF68Ezne8LtaW4PVCHCHiQ+ZijvaKXZQgqZ2Dn5j+lGhoBYi9XC1TWti+4V9nshopllLVtQuqcM1i1nwugxfZc1wRrO6tTmZWcuCYPsTDzsIXbXOpkSEpmGkkp9yHQb3azPkcxtDuIddjR80Abd74eMITzZuyFUuWkuyP3Mcz+aRJ6dkULlwzbBHlPkY1X3ZH9kskOiFMAiArJv0MWkxsZOTs8BFUlvwyEDN/SFMlj2+YfWk+37iycjCotC6PxsSJJbyHAIVICGmZCd0nQTCyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CH0PR11MB5561.namprd11.prod.outlook.com (2603:10b6:610:d4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Mon, 22 May 2023 15:37:15 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%5]) with mapi id 15.20.6411.028; Mon, 22 May 2023 15:37:15 +0000 Message-ID: <4767d62c-0dd0-dd36-11f7-b0e297de2424@intel.com> Date: Mon, 22 May 2023 16:37:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Subject: Re: [PATCH] test/mbuf: fix the forked process segment fault Content-Language: en-US To: Stephen Hemminger CC: Ruifeng Wang , "olivier.matz@6wind.com" , "dev@dpdk.org" , "stable@dpdk.org" , "thomas@monjalon.net" , Justin He , Honnappa Nagarahalli , nd References: <20230522060137.225154-1-ruifeng.wang@arm.com> <2613b0c5-c3a1-60e2-9472-db84fe87cdb3@intel.com> <20230522082159.452ae26c@hermes.local> From: "Burakov, Anatoly" In-Reply-To: <20230522082159.452ae26c@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0102.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::17) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CH0PR11MB5561:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d898450-0172-40f3-e1b0-08db5ada6b21 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n6NNRl7llUzBH0zP9IDsdgIIV6TMbGZd/gkHyuv7L1llbEtDun6TDDACJKSjHwTZiPOzWz4KKTxSHHGuUeKcNU4lSmD2/il76VE8ISkMTjSO3ngg2lKEbAZL63PvWjK8VczKjFuB1X9aDKT8cR39/KTCSXlkVnV5sfe36KS/K8piJsQnMsHONinLUg5XuKZiz0xWiz+lEs7SJffkI7KG1aM08IHg4eCowB3QG3/e7PEdpMRM8vfGxthhecO4fATtvqBhhRC1k6J5Gra0i+2K3GNx/fkVvgZd3p0pr1rbmZizJ0F64vzrebEh6vbLf1Z71WJK2+8UUAbmxoWFsftHIYKe2nQtCM/gRGC/9PcCM0LVcwgMNc5BaLw+HLZGqQSCgmFx6rowSg0XPHAw4XVuJX7zzlIH2bObayTXAh331rHKCPfYeL1UX3QfaU1urtk4ZI7M4lgzWr8iL4fpk3AejK8yNGBckp2AmbvBZfr5Ajc2Ckfq96KVj+BX6K8RiMayVp8q3yJVEYB5x8YKYRG2Dx068QVhDNdRIa2xBfOGDgrnjTKkB+sbCpmc6NHQWlm7YbzvY6yjAEfHoHsBUiGEEn95xhbr3pPWSSz8WVVcx09GDTJ9yEgw7NeeCDAZBxJ3soilwUtnaFJ+AYCCc+ydlw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(346002)(396003)(376002)(366004)(136003)(451199021)(5660300002)(8676002)(8936002)(86362001)(6506007)(6512007)(26005)(53546011)(2906002)(83380400001)(2616005)(36756003)(186003)(6916009)(66556008)(66476007)(4326008)(66946007)(82960400001)(316002)(31686004)(54906003)(38100700002)(478600001)(31696002)(6486002)(41300700001)(6666004)(66899021)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnBqMUkyVjlqTXZZcnczNERPMnB3ckhGaHZzN2N0TGZKcWpWUWYrd0JJZ2FT?= =?utf-8?B?b1lNaWxZVFJwOWs0a0ZhOERvTWg4TkpKcjI2NE5XK3hIR0Vncm45WGwrWFdM?= =?utf-8?B?STJCRkhPSFFYRHhQZ2N4S0hUMDhGNDFFUnJjazlxRitNQ3dkZFd5aHBUMU1a?= =?utf-8?B?QjFFL3hBUkF5ODZ3UG91WGo3MWFtVThLTnR0aFpyNHkvc3hnSzJIYUJLc2Z1?= =?utf-8?B?RmFvd3NydUpja2tRRk1uUTJKcU0wbEZhY0FZRVZyNVRmakZhcDhPSUVjd2RH?= =?utf-8?B?M25Gc290cnFKT1dRdTYxTjFlSmRlcURDZlB5ZUhnYkM4bS80anlEN2R4eGRs?= =?utf-8?B?dXdQbDFpdzdqTE9URHVwWXJqdUllYnNwQTlXVmQ3R25xTkM1eEFIU2RxQUto?= =?utf-8?B?YWFzaG1uaXhFTUFTV3BiMFZhK0FGZXVVWjNwQkt1TG1ja3pHVlZCNExjcUNs?= =?utf-8?B?NU04aTZCV3pacTdyR3EwSWlYeU0yZWN6RmpwNEJIcWdrN1BSbWJGdnZHVjQ2?= =?utf-8?B?dlZ2VmJYaGREUGYxRGFDa2VlLzdrMEp1cjVDbGdXMzZqeHo3YUlvUzhUWE9Q?= =?utf-8?B?R1dEbFQvYng5SFJ1MUdUbTljZnVOY1VBU0tXbWRTQWhHT3dPWXdYNzliTnND?= =?utf-8?B?TVNubnVVcFM5Y2tFbFB5bGtUdWFkWXpoN0JmdTcveXQyQ1F0N3hNazJuMk9l?= =?utf-8?B?NTFZMFRFc1I5YW1Rb1V0YUdmenhHTHdZeUN3NlZDZnRIck51d2YyVnYwRlkv?= =?utf-8?B?U3FPTGRZTTMvZ0NqUEdHdFFpakRpVnlLMHFqVTJwWUpVazRnS1J3WEwvSjU3?= =?utf-8?B?SzArMGpleVZDc0lJYmpVNFpwaUZvTmM3Qmc2YmF2RGRNend0TjNHTmFrMGpM?= =?utf-8?B?NXM0elFIeEVHRlprUXZHVWVoeTc0dVZ0ZjczL2c5alFsZUR4clNHQUJ0Lys5?= =?utf-8?B?aExXNTRuYm9RZnNKaGlqOWV2QkZnRUc1R0F2bDlaQ29jM0pqMlZ0K0ZSM0F4?= =?utf-8?B?QVJybU5PN0FpMVpJVVRjckdwWHBDbTZUMGdpSWdHMWM5QUZxZVEwR0ZqYStW?= =?utf-8?B?c0luLythenQ1bS9Selhuc2VLeEFucVJOaGlqZGRzTUpjMDA3OWg2SWE0K1ZD?= =?utf-8?B?aG9namVQMGZ6bVVDeno3azlFUCtzTGlsOWY3bjFCR01HZWFNdlQrckdvb1Yw?= =?utf-8?B?MFMyVzc4UTBSNnFGLy81Sy8weWU1NE45ald4S201YWdUODhRSWpnVVVRVkVs?= =?utf-8?B?dVN4bzU2MTFIVGhBRzIxeTNJanVNejFvd2lkOFpTZVBoU1pLQVdVb2JNVzFp?= =?utf-8?B?Y0srdDZRUUg5Nk93aTB5bmM2REg0VHdyUllUU1BTWUVNTWI5UURoTjc5WkpG?= =?utf-8?B?S2VianQ3TVY0UGZyejhyQ0hXM1VlbkxMcktybGhSWk5aK3M3MVJEbFVza2RF?= =?utf-8?B?RTFxejZIQlN6LzhhYnoyKytqQTlnTkRBMVhxcXA4V3ZGNEU2Sk1Ram5tdmxN?= =?utf-8?B?SkduUXhmdWNLYkNFMWpwaUtRVkloT05kbXkzRlowTmVWR2lCenZ4d0JTL0Ex?= =?utf-8?B?aVBkWXkzbGlIakpVN293UDJhMTl4RUU2SDFzVXNkb1puVVcwUVlTYnF6RnVS?= =?utf-8?B?aHNJaUlPQzRKbnByTHlyeVk5UDAva25hcUVvQUZwa0xQbG9FL2t4ZndPVjQ3?= =?utf-8?B?TXg4cjdVeHFpWnlsZHNmb3BMUFpndHVZR0lTcFEreUVHVDZQcW5Uc3IyMlo2?= =?utf-8?B?UDNwcm1YMVl4cnpGMzk2TXFITC9JamhjZmVpNlZPQVZjcGhDM0FBOGRRcDJt?= =?utf-8?B?U0RZTHRwb1R6dUJYNjUrekc5TEtSelk2NmRwWFZtWHVFdWxEaFpvOXZtUU9v?= =?utf-8?B?T09GQXZCbzJQeVpNREZNaVRaSU9PUVoyQjl2R3JSUU9OZDlZd1ltbVI3TkF2?= =?utf-8?B?WkNSRmh6Rlc1UkdkWXJ4M2hWd1Rhbnl4UFFGZEJPRnRGTEo5WUFLVTg4R3Rp?= =?utf-8?B?cDI0RjI5dnhhQ0ZTQ0VKaURUQVJJdEdKR0xYR3YwSnd4RnRoNnIvWWNSTjBw?= =?utf-8?B?TFdmaHZNMnZGek43L2NHZmpPU3phV1pqYkdyK05xV0s4Ym5HOFpUTFplamtm?= =?utf-8?B?N2YwQXhReHU3TEFKTUF4MDdLV0NKV2tpRjVEZWRjc0pMMzNBV2lRK3NWdWh0?= =?utf-8?B?UHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4d898450-0172-40f3-e1b0-08db5ada6b21 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 15:37:15.3170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DYb+bveG2MznuJg0rqQUKOcUp3aD8cQlxTG+dhkf1VhgAC5l38gsOkmhxzX8M0zHmIIzLHPLcYKEydUIkR8hhNOPDWjRMGhXmrV76gATF7E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5561 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 5/22/2023 4:21 PM, Stephen Hemminger wrote: > On Mon, 22 May 2023 11:19:24 +0100 > "Burakov, Anatoly" wrote: > >>> >>> This case validates mbuf. IMO there is no need to do validation in a secondary process. >>> Unit test for rte_panic() also uses fork() and could have the same issue. >>> >> >> In that case, rte_panic() test should be fixed as well. >> >> My concern is that ideally, we shouldn't intentionally crash the test >> app if something goes wrong, and calling rte_panic() accomplishes just >> that - which is why I suggested running them in secondary processes >> instead, so that any call into rte_panic happens inside a secondary >> process, and the main test process doesn't crash even if the test has >> failed. >> > > All forks outside of EAL are bad. The test should be removed, it was buggy > when first written. I agree that none of the tests (or anything else in DPDK) should fork, but some things still crash process (as in, cause rte_panic), and the purpose of using fork() was for that. We can rewrite the tests to not fork and instead use other methods (such as spinning up secondary processes), we don't have to remove them. -- Thanks, Anatoly