* [dpdk-stable] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment [not found] <20200521113817.3148-1-adamx.dybkowski@intel.com> @ 2020-05-21 11:38 ` Adam Dybkowski 2020-05-21 11:44 ` Trahe, Fiona 2020-05-21 12:46 ` [dpdk-stable] " Akhil Goyal 2020-05-21 14:48 ` [dpdk-stable] [PATCH v4 0/1] " Adam Dybkowski 1 sibling, 2 replies; 8+ messages in thread From: Adam Dybkowski @ 2020-05-21 11:38 UTC (permalink / raw) To: dev, fiona.trahe, akhil.goyal; +Cc: Adam Dybkowski, stable This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96. Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") Cc: stable@dpdk.org Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com> --- lib/librte_cryptodev/rte_crypto_sym.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h index d9585ecd6..6fc3b8f59 100644 --- a/lib/librte_cryptodev/rte_crypto_sym.h +++ b/lib/librte_cryptodev/rte_crypto_sym.h @@ -269,9 +269,11 @@ enum rte_crypto_auth_algorithm { /**< HMAC using MD5 algorithm */ RTE_CRYPTO_AUTH_SHA1, - /**< 128 bit SHA algorithm. */ + /**< 160 bit SHA algorithm. */ RTE_CRYPTO_AUTH_SHA1_HMAC, - /**< HMAC using 128 bit SHA algorithm. */ + /**< HMAC using 160 bit SHA algorithm. + * HMAC-SHA-1-96 can be generated by setting digest_size to 12. + */ RTE_CRYPTO_AUTH_SHA224, /**< 224 bit SHA algorithm. */ RTE_CRYPTO_AUTH_SHA224_HMAC, -- 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment 2020-05-21 11:38 ` [dpdk-stable] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment Adam Dybkowski @ 2020-05-21 11:44 ` Trahe, Fiona 2020-05-21 12:02 ` [dpdk-stable] [dpdk-dev] " Anoob Joseph 2020-05-21 12:46 ` [dpdk-stable] " Akhil Goyal 1 sibling, 1 reply; 8+ messages in thread From: Trahe, Fiona @ 2020-05-21 11:44 UTC (permalink / raw) To: Dybkowski, AdamX, dev, akhil.goyal; +Cc: stable > -----Original Message----- > From: Dybkowski, AdamX <adamx.dybkowski@intel.com> > Sent: Thursday, May 21, 2020 12:38 PM > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com > Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>; stable@dpdk.org > Subject: [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment > > This patch fixes improper SHA-1 digest size in the enum comment > and also adds the note about HMAC-SHA-1-96. > > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") > Cc: stable@dpdk.org > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment 2020-05-21 11:44 ` Trahe, Fiona @ 2020-05-21 12:02 ` Anoob Joseph 0 siblings, 0 replies; 8+ messages in thread From: Anoob Joseph @ 2020-05-21 12:02 UTC (permalink / raw) To: Trahe, Fiona, Dybkowski, AdamX, dev, akhil.goyal; +Cc: stable > > -----Original Message----- > > From: Dybkowski, AdamX <adamx.dybkowski@intel.com> > > Sent: Thursday, May 21, 2020 12:38 PM > > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; > > akhil.goyal@nxp.com > > Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>; stable@dpdk.org > > Subject: [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment > > > > This patch fixes improper SHA-1 digest size in the enum comment and > > also adds the note about HMAC-SHA-1-96. > > > > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") > > Cc: stable@dpdk.org > > > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com> > Acked-by: Fiona Trahe <fiona.trahe@intel.com> Acked-by: Anoob Joseph <anoobj@marvell.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment 2020-05-21 11:38 ` [dpdk-stable] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment Adam Dybkowski 2020-05-21 11:44 ` Trahe, Fiona @ 2020-05-21 12:46 ` Akhil Goyal 1 sibling, 0 replies; 8+ messages in thread From: Akhil Goyal @ 2020-05-21 12:46 UTC (permalink / raw) To: Adam Dybkowski, dev, fiona.trahe; +Cc: stable > -----Original Message----- > From: Adam Dybkowski <adamx.dybkowski@intel.com> > Sent: Thursday, May 21, 2020 5:08 PM > To: dev@dpdk.org; fiona.trahe@intel.com; Akhil Goyal <akhil.goyal@nxp.com> > Cc: Adam Dybkowski <adamx.dybkowski@intel.com>; stable@dpdk.org > Subject: [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment > > This patch fixes improper SHA-1 digest size in the enum comment > and also adds the note about HMAC-SHA-1-96. > > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") > Cc: stable@dpdk.org > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com> > --- > lib/librte_cryptodev/rte_crypto_sym.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > b/lib/librte_cryptodev/rte_crypto_sym.h > index d9585ecd6..6fc3b8f59 100644 > --- a/lib/librte_cryptodev/rte_crypto_sym.h > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > @@ -269,9 +269,11 @@ enum rte_crypto_auth_algorithm { > /**< HMAC using MD5 algorithm */ > > RTE_CRYPTO_AUTH_SHA1, > - /**< 128 bit SHA algorithm. */ > + /**< 160 bit SHA algorithm. */ > RTE_CRYPTO_AUTH_SHA1_HMAC, > - /**< HMAC using 128 bit SHA algorithm. */ > + /**< HMAC using 160 bit SHA algorithm. > + * HMAC-SHA-1-96 can be generated by setting digest_size to 12. It should be 12 Bytes. And should specify where to set the digest size The name of the field in xform is digest_length and not digest_size. + /**< HMAC using 160 bit SHA algorithm. + * HMAC-SHA-1-96 can be generated by setting + * digest_length to 12 Bytes in auth/aead xforms. + */ > RTE_CRYPTO_AUTH_SHA224, > /**< 224 bit SHA algorithm. */ > RTE_CRYPTO_AUTH_SHA224_HMAC, > -- > 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v4 0/1] cryptodev: fix SHA-1 digest enum comment [not found] <20200521113817.3148-1-adamx.dybkowski@intel.com> 2020-05-21 11:38 ` [dpdk-stable] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment Adam Dybkowski @ 2020-05-21 14:48 ` Adam Dybkowski 2020-05-21 14:48 ` [dpdk-stable] [PATCH v4 1/1] " Adam Dybkowski 1 sibling, 1 reply; 8+ messages in thread From: Adam Dybkowski @ 2020-05-21 14:48 UTC (permalink / raw) To: dev, fiona.trahe, akhil.goyal; +Cc: stable, Adam Dybkowski This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96. v2: * add info about HMAC-SHA-1-96 v3: * fix multi-line comment formatting v4: * fix wording Adam Dybkowski (1): cryptodev: fix SHA-1 digest enum comment lib/librte_cryptodev/rte_crypto_sym.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v4 1/1] cryptodev: fix SHA-1 digest enum comment 2020-05-21 14:48 ` [dpdk-stable] [PATCH v4 0/1] " Adam Dybkowski @ 2020-05-21 14:48 ` Adam Dybkowski 2020-05-21 15:32 ` Akhil Goyal 0 siblings, 1 reply; 8+ messages in thread From: Adam Dybkowski @ 2020-05-21 14:48 UTC (permalink / raw) To: dev, fiona.trahe, akhil.goyal; +Cc: stable, Adam Dybkowski This patch fixes improper SHA-1 digest size in the enum comment and also adds the note about HMAC-SHA-1-96. Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") Cc: stable@dpdk.org Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> Acked-by: Anoob Joseph <anoobj@marvell.com> --- lib/librte_cryptodev/rte_crypto_sym.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h index d9585ecd6..da961a19d 100644 --- a/lib/librte_cryptodev/rte_crypto_sym.h +++ b/lib/librte_cryptodev/rte_crypto_sym.h @@ -269,9 +269,12 @@ enum rte_crypto_auth_algorithm { /**< HMAC using MD5 algorithm */ RTE_CRYPTO_AUTH_SHA1, - /**< 128 bit SHA algorithm. */ + /**< 160 bit SHA algorithm. */ RTE_CRYPTO_AUTH_SHA1_HMAC, - /**< HMAC using 128 bit SHA algorithm. */ + /**< HMAC using 160 bit SHA algorithm. + * HMAC-SHA-1-96 can be generated by setting + * digest_length to 12 bytes in auth/aead xforms. + */ RTE_CRYPTO_AUTH_SHA224, /**< 224 bit SHA algorithm. */ RTE_CRYPTO_AUTH_SHA224_HMAC, -- 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [PATCH v4 1/1] cryptodev: fix SHA-1 digest enum comment 2020-05-21 14:48 ` [dpdk-stable] [PATCH v4 1/1] " Adam Dybkowski @ 2020-05-21 15:32 ` Akhil Goyal 2020-05-24 9:54 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon 0 siblings, 1 reply; 8+ messages in thread From: Akhil Goyal @ 2020-05-21 15:32 UTC (permalink / raw) To: Adam Dybkowski, dev, fiona.trahe, Thomas Monjalon; +Cc: stable > > This patch fixes improper SHA-1 digest size in the enum comment > and also adds the note about HMAC-SHA-1-96. > > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") > Cc: stable@dpdk.org > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com> > Acked-by: Fiona Trahe <fiona.trahe@intel.com> > Acked-by: Anoob Joseph <anoobj@marvell.com> > --- Acked-by: Akhil Goyal <akhil.goyal@nxp.com> Thomas, Can you pick this patch directly on master for this release? The patch is only fixing the comments. Regards, Akhil ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v4 1/1] cryptodev: fix SHA-1 digest enum comment 2020-05-21 15:32 ` Akhil Goyal @ 2020-05-24 9:54 ` Thomas Monjalon 0 siblings, 0 replies; 8+ messages in thread From: Thomas Monjalon @ 2020-05-24 9:54 UTC (permalink / raw) To: Adam Dybkowski; +Cc: dev, fiona.trahe, stable, Akhil Goyal 21/05/2020 17:32, Akhil Goyal: > > > > This patch fixes improper SHA-1 digest size in the enum comment > > and also adds the note about HMAC-SHA-1-96. > > > > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") > > Cc: stable@dpdk.org > > > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com> > > Acked-by: Fiona Trahe <fiona.trahe@intel.com> > > Acked-by: Anoob Joseph <anoobj@marvell.com> > > --- > > Acked-by: Akhil Goyal <akhil.goyal@nxp.com> > > Thomas, > Can you pick this patch directly on master for this release? The patch is only fixing the comments. Applied, thanks ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-05-24 9:54 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200521113817.3148-1-adamx.dybkowski@intel.com>
2020-05-21 11:38 ` [dpdk-stable] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment Adam Dybkowski
2020-05-21 11:44 ` Trahe, Fiona
2020-05-21 12:02 ` [dpdk-stable] [dpdk-dev] " Anoob Joseph
2020-05-21 12:46 ` [dpdk-stable] " Akhil Goyal
2020-05-21 14:48 ` [dpdk-stable] [PATCH v4 0/1] " Adam Dybkowski
2020-05-21 14:48 ` [dpdk-stable] [PATCH v4 1/1] " Adam Dybkowski
2020-05-21 15:32 ` Akhil Goyal
2020-05-24 9:54 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).