From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 652C8A00BE for ; Mon, 8 Jun 2020 09:59:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C9801BE85; Mon, 8 Jun 2020 09:59:12 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id D8C9B1BE85 for ; Mon, 8 Jun 2020 09:59:10 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id u26so13658768wmn.1 for ; Mon, 08 Jun 2020 00:59:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=RhPqiccqU1TPdhtODEeW5af13UFx8VDsLtphVln75A4=; b=r/87kT9p7T/+E2H911R6DpfN8/AaYw8vcY5U5xW6J5BbFmC93JkREE3BCvNSNz1ZZi MiNG6mZeueFrk3gVkUmxBrA1GGP0pIh/iytep5SxmY/ZMDsu6gS8NjNIH34Fz0sVqJhs xzaOTEPAEctgFzFKPRO+b+5Ykc054QGaRPdmrlknyC99oir3L/g+70GT0GGfjuzbHn0x QlLX+Q+JOkxT2H2r5WYpjWwslCfzw+UDuxn1mdeje8k+5R9v9MKaK/bcRF59rva0nlG/ p2DIjfanE0r+jnMb9Zx6ynDS64Fs6fgSb6cv+OdxPV7+1OMFU/sFJaASmpqT28WcqY3A ynUg== X-Gm-Message-State: AOAM531AQIuvKMApW9An0MfABmoc7btdDJievUJiXT1j5btDkiREIpQb mjSOsyzHcH7HnD5F6UAk/wI= X-Google-Smtp-Source: ABdhPJyhCG9vGOSsjUYVXVD+q4vme6eGlzySUPz6POpTMEvzlhfOroBVpiR7vm+pznmUfUKTSD0ezw== X-Received: by 2002:a1c:7206:: with SMTP id n6mr15711988wmc.4.1591603150643; Mon, 08 Jun 2020 00:59:10 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id j11sm22376969wru.69.2020.06.08.00.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 00:59:10 -0700 (PDT) Message-ID: <47e5b78014f365e8ace8ce001079915a51b91b90.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon , stable@dpdk.org Cc: Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko Date: Mon, 08 Jun 2020 08:59:09 +0100 In-Reply-To: <20200606100856.2073664-1-thomas@monjalon.net> References: <20200606100856.2073664-1-thomas@monjalon.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 19.11] net/mlx5: fix build with separate glue lib for dlopen X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Sat, 2020-06-06 at 12:08 +0200, Thomas Monjalon wrote: > If building with option RTE_IBVERBS_LINK_DLOPEN (make) > or ibverbs_link=3Ddlopen (meson), the glue is a separate library > which can be dlopen. > In such case, the object mlx5_glue must be allocated in two places: > one in the glue, and one outside of the glue to be assigned when > loading the glue with dlopen/dlsym. >=20 > When backporting the allocation split for gcc 10, both allocations > were made inside the glue. As a consequence, the symbol is undefined > outside of the glue: > drivers/net/mlx5/mlx5.c: undefined reference to 'mlx5_glue' >=20 > The second allocation is restored outside of the glue, in mlx5.c. >=20 > Fixes: b3e01cd3e46f ("common/mlx5: fix build with -fno-common") >=20 > Signed-off-by: Thomas Monjalon > --- > drivers/net/mlx5/mlx5.c | 4 ++++ > drivers/net/mlx5/mlx5_glue.c | 4 ---- > 2 files changed, 4 insertions(+), 4 deletions(-) Acked-by: Luca Boccassi Thanks for the fix, applied --=20 Kind regards, Luca Boccassi