From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81F9E48B45 for ; Wed, 19 Nov 2025 01:28:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73E7D402DE; Wed, 19 Nov 2025 01:28:05 +0100 (CET) Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) by mails.dpdk.org (Postfix) with ESMTP id C09554027A; Wed, 19 Nov 2025 01:28:02 +0100 (CET) Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id E66791D00189; Tue, 18 Nov 2025 19:28:01 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Tue, 18 Nov 2025 19:28:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1763512081; x=1763598481; bh=MMVzV0wkcFEqqOAuT8i90lQJs1K0pzmpWHpQkZSZxX0=; b= qTMG0zBmg8WMFDIg5F2SmZSeb7BgCNNga5/SWRv26bPWbZSPndwvh9bIqQiEbmON zrcxFYJ7nJqvs05NRytn9Be55JFsWvF9VG3FxmMpII6Q4WB4OYhN3QeCX3ghgQgn lkm3Y2XOd4MwnLkvAyJNrsg1wFfL5trfDt8/BdNYpSn0zdtc1GtbKMe5qO2d33ka t2ISsQx3rw7HuyesaZve1GXiuXVUZxmwmGh+8Joztu9S8P7+6IurlRF4NGqHnlew H/wfCyV4ZJCSiZrh2wuuc+9HMOE+kO+L7xV/bQS/pFLMznySdt9yJMGSgmIBLTLY sh3Ql8mBQ9vuo954HuB8zA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1763512081; x= 1763598481; bh=MMVzV0wkcFEqqOAuT8i90lQJs1K0pzmpWHpQkZSZxX0=; b=0 Uh/QPfScerdrLxtvcf4Qe8k6Q+pX/LTZr9Qfd1JvptSpZl0HqfvSRwdZYlplVlJc vad2PsonDWWmzVwf/w1ZLjSUR8hnqJLcWk9jYbQ+inlDK9/l0UtQ71Hax7NwgP97 RUmXP/95Y/D6V69byPBatTV7Z2VRVQliZXb4VZrWKX58RBB5iOPYiEPNZ/BqiS9V DoWI/DKVHmz16DPRngfq3/UDGHa90wb1ULJYxbUjpwUQT3NS3uZJRlY9PmO/ONGu i5ZqtT7wfYwS2V299PxZ2cjlDumgfEKr4ksDqOni+ORuGffh19iQ1RGjWgmkjE5/ 2laI4rSEx5s7cYHc6aKSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvvddvjeehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeekgfdv uefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhnsggprhgtphhtthhopeehpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopegtfhhonhhtrghinhesrhgvughhrghtrd gtohhmpdhrtghpthhtoheprhhjrghrrhihsehrvgguhhgrthdrtghomhdprhgtphhtthho pehsthgvphhhvghnsehnvghtfihorhhkphhluhhmsggvrhdrohhrghdprhgtphhtthhope hsthgrsghlvgesughpughkrdhorhhgpdhrtghpthhtohepuggvvhesughpughkrdhorhhg X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Nov 2025 19:28:00 -0500 (EST) From: Thomas Monjalon To: Christophe Fontaine , Robin Jarry Cc: Stephen Hemminger , stable@dpdk.org, dev@dpdk.org Subject: Re: [PATCH dpdk v2] net: ipv6 link local compliance with rfc 4291 Date: Wed, 19 Nov 2025 01:27:58 +0100 Message-ID: <4832942.kQq0lBPeGt@thomas> In-Reply-To: <3249247.iZASKD2KPV@thomas> References: <20251114105751.54802-3-rjarry@redhat.com> <20251118174526.321856-1-rjarry@redhat.com> <3249247.iZASKD2KPV@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 19/11/2025 01:07, Thomas Monjalon: > 18/11/2025 18:45, Robin Jarry: > > From: Christophe Fontaine > > > Modified EUI-64 format interface identifiers are formed by inverting > > > the "u" bit (universal/local bit in IEEE EUI-64 terminology) when > > > forming the interface identifier from IEEE EUI-64 identifiers. > [...] > > - ip->a[8] = mac->addr_bytes[0]; > > + ip->a[8] = mac->addr_bytes[0] ^ RTE_ETHER_LOCAL_ADMIN_ADDR; > > In all other places, we use the operator OR, so I'm not sure about this XOR. > Also, rte_is_universal_ether_addr() and rte_is_local_admin_ether_addr() > are comparing this bit with 0. > Is this bit always 0 by default in MAC addresses? After checking with Stephen, it appears that XOR is really desired. This bit must be inverted, so 0 is local and 1 is universal. Adding this comment in the code to avoid confusion in future: /* * The "u" bit (universal/local bit in IEEE EUI-64 terminology) * must be inverted for IPv6 link local address. * 0 means local scope, 1 means universal scope. */ Applied, thanks.