From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E95EFA0A0B for ; Thu, 28 Jan 2021 14:30:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD6D440683; Thu, 28 Jan 2021 14:30:14 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 92D2F40395; Thu, 28 Jan 2021 14:30:12 +0100 (CET) IronPort-SDR: 19x/b/AE+H26Vm/E7whCbadfzAnvtm6dv4ctzwEX/GJo2KlMJ1+XgIK+6PACyjbjRXPIwo3rHV esQ276x+Xmsw== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="199064275" X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="199064275" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 05:30:11 -0800 IronPort-SDR: eWubiouFUaTu2D89i4n7wP8g76qpLsTQjeCQvGyCq1sUTQia18XBSV+JEYwtZOLXnkNxziKzsO //DnYAzZVYhQ== X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="388815097" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.127]) ([10.213.197.127]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 05:30:09 -0800 To: Wei Huang , dev@dpdk.org, rosen.xu@intel.com, qi.z.zhang@intel.com Cc: stable@dpdk.org, tianfei.zhang@intel.com References: <1611643528-18311-1-git-send-email-wei.huang@intel.com> <1611643528-18311-4-git-send-email-wei.huang@intel.com> From: Ferruh Yigit Message-ID: <48942425-fab3-9357-5ff3-6c06b80f8062@intel.com> Date: Thu, 28 Jan 2021 13:30:06 +0000 MIME-Version: 1.0 In-Reply-To: <1611643528-18311-4-git-send-email-wei.huang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [PATCH v12 3/4] raw/ifpga: add fpga helper function X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 1/26/2021 6:45 AM, Wei Huang wrote: > Below helper functions are used to implement OPAE application. > 1. ifpga_rawdev_lock() and ifpga_rawdev_unlock() protect FPGA access > in multiproces. Why driver needs to expose the lock APIs to the application? Can't application use its own locking mechanism for multiprocess, and driver can use its own locking for its needs. Driver exposing locking internals to applications doesn't look right, but I don't know the full usecase. > 2. ifpga_rawdev_get_rsu_stat() and ifpga_rawdev_set_rsu_stat() record > current RSU status and progress. > 3. ifpga_rawdev_get_phy_info() get information of connected retimer. > 4. ifpga_rawdev_partial_reconfigure() do partial reconfiguration. > 5. ifpga_rawdev_cleanup() free software resources allocated for driver. > > Signed-off-by: Wei Huang > Acked-by: Tianfei Zhang > Acked-by: Rosen Xu <...>