From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B2F2A0A06 for ; Wed, 20 Jan 2021 01:49:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49093140E99; Wed, 20 Jan 2021 01:49:55 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 94535140DE5; Wed, 20 Jan 2021 01:49:52 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2FC145C010E; Tue, 19 Jan 2021 19:49:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 19 Jan 2021 19:49:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= kiuYSvliRPohKnRUbK0SafuhPCcMZMGLUuAsYW6Y02s=; b=AZayF7gJN2PyguPA NLs7UC3N4FuXszR/0hfWfR6EzRTJc0zlL9g0D0HKekch65bBqG17PbgwtNwolkzJ QMbPqlnegTTFkKrAAm/mpgAQc/8EBO+NPb0rGGeRkvNLczDfcOUOaJk7IrGbMcfq mcleKe3nJAqiE30TspK3S+FU0A5GpCiqYHg4UJGlrvVwqiMGl69GjVucKtjGEEPV tdSekudf4re0ZSuu2dbLHc3MR02WEse8VBQwKbumeabp4AwEBOgw5IBxusFZ4BTk y2SSWDr0FlynPWIYHf1rjWfO/MmhuLu0cw5eB/HAvtMlDIZwA72yIEgTZcmxKbFl EEypbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=kiuYSvliRPohKnRUbK0SafuhPCcMZMGLUuAsYW6Y0 2s=; b=BFMaI+x2SMLfM8sTuebSqlLgB+IFGu0cotb178YDHnVeApilH+eC4xn6h jQ6LlCgUe0iVOcz71Fw6VW/OYWI38X92N5qHxRMPiewVkRb49VbA8QVZk3sWPLXb 71hTRGKCbEvSvcENglKZyQRc0pqqeoYwcF20j1V3YKaWxR+W5jxbx3OdZgC3sUxN Bia0C5gNVVak4h2mw4F7hlmcs4Wlk+CnBwTZUURkXVl3Vwu1CgUM3wcpfeClXnTt qcn8J8/mkQrFoSwppP3q5QhAUB+/kVxdMySUPnyaNLddwX5oCXLdDADA4lpnim/q JXmpVKpd+RlnEhYqh/9emTL0SiVCA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddugddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CED2D24005B; Tue, 19 Jan 2021 19:49:50 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: stable@dpdk.org, dev , Honnappa.Nagarahalli@arm.com, Andrew Boyer Date: Wed, 20 Jan 2021 01:49:49 +0100 Message-ID: <4894559.8TOBBnaypU@thomas> In-Reply-To: <0EF8D1A0-3838-442A-A4E9-006258035C34@pensando.io> References: <20210111135559.1169775-1-bruce.richardson@intel.com> <0EF8D1A0-3838-442A-A4E9-006258035C34@pensando.io> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] build: provide suitable error for "both" libraries option X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 11/01/2021 17:19, Andrew Boyer: > > On Jan 11, 2021, at 8:55 AM, Bruce Richardson wrote: > >=20 > > Rather than having the DPDK configuration error out when linking apps > > and examples when "both" is select for "default_library" option, we can > > detect that setting earlier in the build config and provide a suitable > > error message to the user. > >=20 > > CC: stable@dpdk.org > >=20 > > Signed-off-by: Bruce Richardson > > --- > > +if get_option('default_library') =3D=3D 'both' > > + error( ''' > > + Unsupported value "both" for "default_library" option. > > + > > + NOTE: DPDK always builds both shared and static libraries. Please= set > > + "default_library" to either "static" or "shared" to select default= linkage > > + for apps and any examples''') >=20 > Should there be a period after =E2=80=98examples=E2=80=99? >=20 > Reviewed-by: Andrew Boyer Applied with above fixup, thanks