From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id BABCE5398; Sun, 18 Nov 2018 23:46:00 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 51B9F21C4D; Sun, 18 Nov 2018 17:46:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 18 Nov 2018 17:46:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=0kZRpnI2inHnM8sA8spjR2QnzE6Aw8clkHJEaDIDxLg=; b=D9KjcDJC+15Z E0P+WxSS5hBCDaHfdnrkyQV1DqNojPJ0cZ9ROGmlvfIrcFI0hqh7vlTDzBXcihyW hwU9AxBVzCfpd49KeaJZ3LNxyy2IVHQ6VpuyNYDLOAI1szRQHFntyRw1DbpLoGuu DgFXm1s2SJFnhk6DKDIIPCVXvJS0Chg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=0kZRpnI2inHnM8sA8spjR2QnzE6Aw8clkHJEaDIDx Lg=; b=Yo9mHLqg5meAHfQ1PI4GDB+TP0hQ1/BSPdV6hHy7/vkSXjrfHSBbCqw/q Je7/mJcljj7OS86fGZPrIqWmePitgv5SgO/nHe0p+2BGTgWxSGaWBtkkml1QZYHP TtfAejzt2CoulNFkvyVERM1aIlbz+sQ+AdVnb01ENHQg8iAxDiVxS3tXeyAiEJvb vURUuP4nwQE8kgYzpPld8WQB9eD5ec90xw+bfH/vh5U8uWzAtRs/fME7drpXMy0O ZmemWe5mZjFyyRkSosRtRth9QkXe3MSI9wmSE2JW8UHWqBIPaQu0byeqDj150awQ 9g/m/GnLpVEvlibuwQNHz+an/OdtA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 74D2FE405D; Sun, 18 Nov 2018 17:45:59 -0500 (EST) From: Thomas Monjalon To: Rami Rosen Cc: dev@dpdk.org, stable@dpdk.org Date: Sun, 18 Nov 2018 23:45:58 +0100 Message-ID: <4993609.zzt5v1ZH8Z@xps> In-Reply-To: <20180822143731.3971-1-ramirose@gmail.com> References: <20180822143731.3971-1-ramirose@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/1] remove unnecessray fw declarations X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2018 22:46:01 -0000 22/08/2018 16:37, Rami Rosen: > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -435,9 +435,6 @@ static int eth_event_callback(portid_t port_id, > static void eth_dev_event_callback(char *device_name, > enum rte_dev_event_type type, > void *param); > -static int eth_dev_event_callback_register(void); > -static int eth_dev_event_callback_unregister(void); I has been fixed by 2049c5113fe8 ("app/testpmd: use hotplug failure handler"). However I agree that some forward declarations could be removed, ideally all. Generally speaking, a lot of cleanup could be done in this file.