From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <vipin.varghese@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 21CAA1B144; Wed, 5 Dec 2018 05:37:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2018 20:37:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,316,1539673200"; d="scan'208";a="281025111" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 04 Dec 2018 20:37:15 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Dec 2018 20:37:15 -0800 Received: from bgsmsx153.gar.corp.intel.com (10.224.23.4) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Dec 2018 20:37:15 -0800 Received: from bgsmsx101.gar.corp.intel.com ([169.254.1.234]) by BGSMSX153.gar.corp.intel.com ([169.254.2.9]) with mapi id 14.03.0415.000; Wed, 5 Dec 2018 10:07:12 +0530 From: "Varghese, Vipin" <vipin.varghese@intel.com> To: "Yang, Qiming" <qiming.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Yang, Qiming" <qiming.yang@intel.com>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH] lib: add warning for NULL pointer Thread-Index: AQHUjFM7tPWsNVxV5k2OYe3lpX89UaVvjy3A Date: Wed, 5 Dec 2018 04:37:11 +0000 Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C4BF6@BGSMSX101.gar.corp.intel.com> References: <20181205115531.17073-1-qiming.yang@intel.com> In-Reply-To: <20181205115531.17073-1-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDExNThkZjQtODQ3MC00MzM2LWJmNTUtMTcxMzhmNTcyOGMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYVd2c3NvRVpVODNxQWVnVFhrbmlNbk9LU2hhRXg0MWFhN3k1c3Z4N0VEUUNVRDVyOXpnYkFLTnBiTTRNVzVRKyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] lib: add warning for NULL pointer X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 05 Dec 2018 04:37:17 -0000 Hi, Should not the warning be stated for ' alloc_completion' failure Snipped > flows->num_packets * flows->categories); > } >=20 > + if (flows->last_cmplt =3D=3D NULL) > + RTE_LOG(WARNING, MALLOC, "packet tries allocate > failed"); Why is that we want to try this outside block? > + > /* set completion parameters and starting index for this slot */ > parms[n].cmplt =3D flows->last_cmplt; > transition =3D > -- > 2.9.5