From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A244EA0A0A for ; Tue, 18 May 2021 18:41:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89A55410FF; Tue, 18 May 2021 18:41:14 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 818DA40041; Tue, 18 May 2021 18:41:12 +0200 (CEST) IronPort-SDR: EtWVd5ZEefoopXoLbY7+4qS6o27vG/7DJzIwPSkTCygowp+IBDW0iJCmM+mbNWSLbJanhuuhW+ K9LgYCixf/sw== X-IronPort-AV: E=McAfee;i="6200,9189,9988"; a="261987083" X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="261987083" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 09:41:10 -0700 IronPort-SDR: HZ0WIEzTTSqa6RoQ6VJcoTfzU0HiqpodRZPmmADx79Wqp/lhF6UL0iSRVf6M6Wpgqv8BpR6SBN sqOtUgfEQeYQ== X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="439518689" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.73]) ([10.213.224.73]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 09:41:08 -0700 To: Ivan Malov , dev@dpdk.org Cc: Andy Moreton , stable@dpdk.org, Andrew Rybchenko References: <20210518151012.14277-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <4bb2b529-c64a-48d1-7816-eacf61c93ee5@intel.com> Date: Tue, 18 May 2021 17:41:07 +0100 MIME-Version: 1.0 In-Reply-To: <20210518151012.14277-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH 1/2] common/sfc_efx/base: limit reported MCDI response length X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 5/18/2021 4:10 PM, Ivan Malov wrote: > From: Andy Moreton > > MCDI helper routines in libefx include length checks for response > messages, to ensure that short replies and optional fields are > handled correctly. > > If the MCDI response message from the firmware is larger than the > caller's buffer then the response length reported to the caller > should be limited to the buffer size. Otherwise length checks in > the caller may allow reading past the end of the buffer. > > Fixes: 6f619653b9b1 ("net/sfc/base: import MCDI implementation") > Cc: stable@dpdk.org > > Signed-off-by: Andy Moreton > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko Series applied to dpdk-next-net/main, thanks.