From: Kevin Traynor <ktraynor@redhat.com>
To: Dengdui Huang <huangdengdui@huawei.com>, stable@dpdk.org
Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com
Subject: Re: [PATCH 24.11 2/2] net/hns3: fix Rx packet without CRC data
Date: Tue, 22 Jul 2025 14:03:30 +0100 [thread overview]
Message-ID: <4bb96162-e679-4592-992f-fca2875cf8da@redhat.com> (raw)
In-Reply-To: <20250722105710.247052-2-huangdengdui@huawei.com>
On 22/07/2025 11:57, Dengdui Huang wrote:
> [ upstream commit 99c065da47c432e9529f761b457cde1fd8c89f20 ]
>
> When KEEP_CRC offload is enabled, the CRC data is still stripped
> in following cases:
> 1. For HIP08 network engine, the packet type is TCP and the length
> is less than or equal to 60B.
> 2. For HIP09 network engine, the packet type is IP and the length
> is less than or equal to 60B.
>
> So driver has to recaculate packet CRC for this rare scenarios.
>
> In addition, to avoid impacting performance, KEEP_CRC is not
> supported when NEON or SVE algorithm is used.
>
> Fixes: 8973d7c4ca12 ("net/hns3: support keeping CRC")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> Acked-by: Huisong Li <lihuisong@huawei.com>
> Acked-by: Jie Hai <haijie1@huawei.com>
> ---
> drivers/net/hns3/hns3_ethdev.c | 2 +
> drivers/net/hns3/hns3_ethdev.h | 23 +++++
> drivers/net/hns3/hns3_rxtx.c | 119 +++++++++++++++++++++-----
> drivers/net/hns3/hns3_rxtx.h | 3 +
> drivers/net/hns3/hns3_rxtx_vec.c | 3 +-
> drivers/net/hns3/hns3_rxtx_vec_neon.h | 19 ----
> drivers/net/hns3/hns3_rxtx_vec_sve.c | 3 +-
> 7 files changed, 128 insertions(+), 44 deletions(-)
>
Thanks Dengdui. I will apply this one with the batch in a couple of days.
next prev parent reply other threads:[~2025-07-22 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 10:57 [PATCH 24.11 1/2] net/hns3: fix CRC data segment Dengdui Huang
2025-07-22 10:57 ` [PATCH 24.11 2/2] net/hns3: fix Rx packet without CRC data Dengdui Huang
2025-07-22 13:03 ` Kevin Traynor [this message]
2025-07-22 13:02 ` [PATCH 24.11 1/2] net/hns3: fix CRC data segment Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bb96162-e679-4592-992f-fca2875cf8da@redhat.com \
--to=ktraynor@redhat.com \
--cc=fengchengwen@huawei.com \
--cc=huangdengdui@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).