From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA46046BE7 for ; Tue, 22 Jul 2025 15:03:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE78E4003C; Tue, 22 Jul 2025 15:03:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CB9584003C for ; Tue, 22 Jul 2025 15:03:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753189417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HsnR7lW7l8HGHCLhjjFQFfr+cOT5HO7qTq/FXVWkCYM=; b=G5yJ/9uXnLJv7/g7YrfaHrPuwLKp6X5urXGTGrzcCrB6p8tvhpoKjMjsIFaEkKCqba35zt ANjhY0Y4p/igKkQbPamLyp0HgSdtc4sTtz68dU0H1prbFGdSsTHVUMCQxKMX8fsBSS3aGX b3h0USGUGABDZX6jhE/i07fCrkXgrUo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-gUoJ92wcN_CUpsf8jTku5g-1; Tue, 22 Jul 2025 09:03:35 -0400 X-MC-Unique: gUoJ92wcN_CUpsf8jTku5g-1 X-Mimecast-MFC-AGG-ID: gUoJ92wcN_CUpsf8jTku5g_1753189415 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a6d1394b07so3555961f8f.3 for ; Tue, 22 Jul 2025 06:03:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753189414; x=1753794214; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HsnR7lW7l8HGHCLhjjFQFfr+cOT5HO7qTq/FXVWkCYM=; b=ieCuziSqwfJY9DVQcwtJGdhJ2rplCuegcjTVzC/ZVnQ4E9eujwTEcUHypel7e9wy2s IB6FAUntrwHDYVYcORoJYr5TT+3lhmh8AQZVFRsxO+X6f3GZU0L2qSpWfAapRWG0wdLH u5gq5AoZlQsMzeqShDOH6WhpFXkmSWS2BpNIfq+I/zA/aZWlrQl2UeAeR6DDbuwxwxxL 0iFUONrQYdRIyDrvwZwSmY3U1RVbwE8RBxaKvjYVkmGnlin9IFV6eepcAzW6VJMb8ucd RJQupARATMQOX/8XF5+slioiePz3hU9t63lJvsOAR7Bnk3p97+Q7RZ2WncNTnb3T7+X3 Vf9g== X-Forwarded-Encrypted: i=1; AJvYcCXMYg9EQ27tO3u2H/iR+e++Lp/VEhs9e2tIO8jAKWFQgKe+TyxI1iZIN0bwN+HaOXrX1qWLB9Y=@dpdk.org X-Gm-Message-State: AOJu0YzTWiN08oWjC3sWQCB/ruTigQd19TQQZFsQgibhv2oREMif4S4O iPHo0zL5brgQfcCz7e4nSK6wLBdLMWQWNrq0sw/ZS23lxQD0IhIkYwG0EN5lKb41gaK2X2Uw9DD I6yRFtCFTbBg7SL2vwumKVgHz9glOp1wNGsdOhbKviO7nqrPIlNmgXxVP X-Gm-Gg: ASbGnct3jFzmqez/lA+nSU5NX1aZVO5hEOvcZAddcfK7uS9PBb/X6MpGsqROJQco3Lh virnwHOm6metO8MXzgq1TFz6y+sIs7MTqttHIHelpK/E+YWSgzVPR83nzCZS9jRiJZtdgoV/8GO Rmlhrkug6wgm+Ofy6XO7ag5tj4vkLCLMGVLwiSiNTAQXVOoAYJZlN7oIsFwqYn6BvsBqbwoI71E 5w6KNxx+Ty2ga4cx73Xu7XN4MMPxgFsFU+joRiKPmBpidbvX5YcNTSC0zEjvsf8tveZCGqubZXe AVyKHQloftXDLDIsn1LDvdqefMr+aTsJpTbB1Scsng== X-Received: by 2002:a5d:5d85:0:b0:3a6:ec41:b9df with SMTP id ffacd0b85a97d-3b60dd82984mr18631780f8f.49.1753189414277; Tue, 22 Jul 2025 06:03:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGViEtaC5Mmj5SYyF/QKFohAxiIAkWG39xkZirrQ075lMs3udJStapFQK1I2WUHkRmMv9ZSDQ== X-Received: by 2002:a5d:5d85:0:b0:3a6:ec41:b9df with SMTP id ffacd0b85a97d-3b60dd82984mr18631600f8f.49.1753189412356; Tue, 22 Jul 2025 06:03:32 -0700 (PDT) Received: from [192.168.0.56] ([78.16.130.126]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca5c952sm13415605f8f.86.2025.07.22.06.03.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jul 2025 06:03:31 -0700 (PDT) Message-ID: <4bb96162-e679-4592-992f-fca2875cf8da@redhat.com> Date: Tue, 22 Jul 2025 14:03:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 24.11 2/2] net/hns3: fix Rx packet without CRC data To: Dengdui Huang , stable@dpdk.org Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com References: <20250722105710.247052-1-huangdengdui@huawei.com> <20250722105710.247052-2-huangdengdui@huawei.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20250722105710.247052-2-huangdengdui@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pW4KFSb697xdtvUa2aPydT4EegtexgeCGSZQ0bed5cE_1753189415 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 22/07/2025 11:57, Dengdui Huang wrote: > [ upstream commit 99c065da47c432e9529f761b457cde1fd8c89f20 ] > > When KEEP_CRC offload is enabled, the CRC data is still stripped > in following cases: > 1. For HIP08 network engine, the packet type is TCP and the length > is less than or equal to 60B. > 2. For HIP09 network engine, the packet type is IP and the length > is less than or equal to 60B. > > So driver has to recaculate packet CRC for this rare scenarios. > > In addition, to avoid impacting performance, KEEP_CRC is not > supported when NEON or SVE algorithm is used. > > Fixes: 8973d7c4ca12 ("net/hns3: support keeping CRC") > Cc: stable@dpdk.org > > Signed-off-by: Dengdui Huang > Acked-by: Huisong Li > Acked-by: Jie Hai > --- > drivers/net/hns3/hns3_ethdev.c | 2 + > drivers/net/hns3/hns3_ethdev.h | 23 +++++ > drivers/net/hns3/hns3_rxtx.c | 119 +++++++++++++++++++++----- > drivers/net/hns3/hns3_rxtx.h | 3 + > drivers/net/hns3/hns3_rxtx_vec.c | 3 +- > drivers/net/hns3/hns3_rxtx_vec_neon.h | 19 ---- > drivers/net/hns3/hns3_rxtx_vec_sve.c | 3 +- > 7 files changed, 128 insertions(+), 44 deletions(-) > Thanks Dengdui. I will apply this one with the batch in a couple of days.