Re: [PATCH] net/nfp: fix RSS failed on VXLAN inner layer

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 10/16/2024 9:17 AM, Chaoyong He wrote:
> From: Long Wu <long.wu@corigine.com>
> 
> Before the commit 5126a904fae0
> ("net/nfp: use offload flag to control VXLAN configuration"),
> in the initial logic 'nfp_net_start()' will enable the
> NFP_NET_CFG_CTRL_VXLAN flag if hardware has the capability,
> 'udp_tunnel_port_add()' and 'udp_tunnel_port_del()' just do
> the port add and delete action.
> 
> But the commit 5126a904fae0
> ("net/nfp: use offload flag to control VXLAN configuration")
> added another limitation of RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO over
> the VXLAN inner RSS flag of Tx wrongly, which caused the
> NFP_NET_CFG_CTRL_VXLAN cannot be enable, thus 'udp_tunnel_port_add()'
> and 'udp_tunnel_port_del()' can not done their works.
> 
> This commit fix the problem and do a little of enhancement to the
> initial logic, move the logic of enable NFP_NET_CFG_CTRL_VXLAN into the
> 'udp_tunnel_port_add()', and add the logic of disable
> NFP_NET_CFG_CTRL_VXLAN into the 'udp_tunnel_port_del()', thus the whole
> solution more complete and easier to understand.
> 
> Fixes: 5126a904fae0 ("net/nfp: use offload flag to control VXLAN configuration")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>

Applied to dpdk-next-net/main, thanks.