From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0257CA32A4 for ; Fri, 25 Oct 2019 21:55:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44EC21E550; Fri, 25 Oct 2019 21:55:05 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 8EDBB1E535; Fri, 25 Oct 2019 21:55:00 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id v5so1801201ply.10; Fri, 25 Oct 2019 12:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ykEauSwzLtGmKFueIC3LkL6X4bo0/0FwLQ35kQ+FlT4=; b=lUzwYPF8lZV0YMKDFjKO9kTdCzUMNg5pXJIKLOtTlU+hHLPbUDQKldbTUGePtLbZnT jZya1LLxekF1oszbGfeDwW9tjcyvNFjfV/CkVcNJXirOSYC6g9S+/3DrUcvjH1fdbbpU iShBp0zWDO+6l0C0vxr74GiA/JlG3pt/RTb9RqV4Jdq8NGW17l25/rVXgJnYCtlOiIMX 0E7EyuaJt2AaGpNQeeclqAK0qUHVLLd/vO7v6puYLLQNiZM6yyu8xZ0j1vrUpKCFv3D+ up8+8aOXeJA91NxsVU0jR96q9MVZkY8dzpO54sSBJSwWogDReaDUjdW1MAAev5RDJGIS lUvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ykEauSwzLtGmKFueIC3LkL6X4bo0/0FwLQ35kQ+FlT4=; b=kAPbvvyu/cbkcBjlqjEVyHkiWikAwfnMm8pbRnSlhYOxJttKXOtUkpXiEx6+jIjsKs O0vkHAGuk6WHDOydfkRiZbIBKgMgzrJcaiW/uWrtZ+xH+FP1ZcPtisnbAdMXt3EUEKds jr8trzNmPzG9CaNUvkA2i16UOtE8dZyWJHmzixyIlA5vdHYlwnBmQM8Ale1WefEH1KWa nq6waOhwvNbOF30md9tZph9vXrjmdun0Y8lQH6Oda85fjWQXp7jLHuFOmpZWDGcFco2E QIMpsXs0OONJVuRYWwmAxcDxb6F3bjQFbZW5T+u4jv4GqDqPV7RgLyxH1K9pMJ6dui5P KtGQ== X-Gm-Message-State: APjAAAX5h7CuV9KhOh4i/PTdjrR7o48dG9mGVfLY+AgRKg/xtUXEBBEy 4u6R65Kl0swmm1eqVJ+3H/w= X-Google-Smtp-Source: APXvYqwJ81FthSwWN6R33ATT58rg1JKYFrTqJGBlYCeJvHJ5z7khWXAtAo00Pg0uKCGuf1POmRFdqA== X-Received: by 2002:a17:902:122:: with SMTP id 31mr5820034plb.257.1572033299700; Fri, 25 Oct 2019 12:54:59 -0700 (PDT) Received: from mugwort.local ([2400:4050:c8c2:de00:1554:d6ef:cd96:1f35]) by smtp.gmail.com with ESMTPSA id m2sm3101787pff.154.2019.10.25.12.54.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Oct 2019 12:54:58 -0700 (PDT) To: David Marchand Cc: "Burakov, Anatoly" , dev , dpdk stable , Yasufumi Ogawa References: <20190711103148.9187-1-yasufum.o@gmail.com> <20190724082031.45546-1-yasufum.o@gmail.com> <20190724082031.45546-2-yasufum.o@gmail.com> From: Yasufumi Ogawa Message-ID: <4c23f77e-cf00-2785-f0ce-34081c393011@gmail.com> Date: Sat, 26 Oct 2019 04:54:56 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v4 1/1] fbarray: get fbarrays from containerized secondary X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi David, Thank you for your comments. On 2019/10/26 0:36, David Marchand wrote: > On Fri, Oct 11, 2019 at 11:36 AM David Marchand > wrote: >> >> Some comments. > > ping. > > >> >> The title does not reflect the observed issue. I would like to consider to revise it. >> I understand that secondary processeses can't be started from a docker >> container. I've confirmed that secondary process can be started as a container app with SPP, and DPDK v18.08 and v19.08. SPP is a multi-process app supporting container usecases. http://git.dpdk.org/apps/spp/ >> The patch title should reflect this. >> >> On Wed, Jul 24, 2019 at 10:20 AM wrote: >>> >>> From: Yasufumi Ogawa >>> >>> In secondary_msl_create_walk(), it creates a file for fbarrays with its >>> PID for reserving unique name among secondary processes. However, it >>> does not work if secondary is run as app container because each of >>> containerized secondary has PID 1. To reserve unique name, use hostname >>> instead of PID because hostname is assigned as a short form of 64 >>> digits full container ID in docker. >>> >>> Cc: stable@dpdk.org >> >> I don't think we want to backport this behavior change. This issue was included from DPDK v18.08, and some users of SPP are still using stable 18.11. So, I would appreciate if you agree to backport. >> >>> >>> Signed-off-by: Yasufumi Ogawa >>> --- >>> lib/librte_eal/linux/eal/eal_memalloc.c | 28 +++++++++++++++++++++++-- >>> 1 file changed, 26 insertions(+), 2 deletions(-) >>> >>> diff --git a/lib/librte_eal/linux/eal/eal_memalloc.c b/lib/librte_eal/linux/eal/eal_memalloc.c >>> index 1f6a7c18f..356b304a8 100644 >>> --- a/lib/librte_eal/linux/eal/eal_memalloc.c >>> +++ b/lib/librte_eal/linux/eal/eal_memalloc.c >>> @@ -1366,6 +1366,7 @@ secondary_msl_create_walk(const struct rte_memseg_list *msl, >>> struct rte_memseg_list *primary_msl, *local_msl; >>> char name[PATH_MAX]; >>> int msl_idx, ret; >>> + char proc_id[33] = { 0 }; /* 32bytes is enough if using hostname */ >> >> This variable only makes sense in the if (getpid() == 1) branch, >> please move it there, and see below comment about using gethostname(). Sure. It works correctly in secondary app container and I should replace it. >> >>> >>> if (msl->external) >>> return 0; >>> @@ -1375,8 +1376,31 @@ secondary_msl_create_walk(const struct rte_memseg_list *msl, >>> local_msl = &local_memsegs[msl_idx]; >>> >>> /* create distinct fbarrays for each secondary */ >>> - snprintf(name, RTE_FBARRAY_NAME_LEN, "%s_%i", >>> - primary_msl->memseg_arr.name, getpid()); >>> + /* If run secondary in a container, the name of fbarray file should >>> + * not be decided with pid because getpid() always returns 1. >>> + * In docker, hostname is assigned as a short form of full container >>> + * ID. So use hostname as unique ID among containers instead. >> >> I understand this is how it works for docker. >> Is this the same in other container environments? Umm... I've tested on other than docker because I don't have test environment. I am not sure which of container runtimes should be supported actually. I think it is enough as the first step to fix this issue of docker. Moreover, the essential problem is that getpid() returns 1 in docker or not. I am also not sure which of environments other than docker should be supported if necessary. What do you think? >> >> >>> + */ >>> + if (getpid() == 1) { >>> + FILE *hn_fp; >>> + hn_fp = fopen("/etc/hostname", "r"); >> >> Why not use gethostname() ? >> Plus, this api defines the maximum size of the hostname as HOST_NAME_MAX bytes. Yes. I should use gethostname() and replace hardcoded size with HOST_NAME_MAX. Thanks, Yasufumi >> >>> + if (hn_fp == NULL) { >>> + RTE_LOG(ERR, EAL, >>> + "Cannot open '/etc/hostname' for secondary\n"); >>> + return -1; >>> + } >>> + >>> + /* with docker, /etc/hostname just has one entry of hostname */ >>> + if (fscanf(hn_fp, "%32s", proc_id) == EOF) { >>> + fclose(hn_fp); >>> + return -1; >>> + } >>> + fclose(hn_fp); >>> + } else >>> + sprintf(proc_id, "%d", (int)getpid()); >>> + >>> + snprintf(name, RTE_FBARRAY_NAME_LEN, "%s_%s", >>> + primary_msl->memseg_arr.name, proc_id); >>> >>> ret = rte_fbarray_init(&local_msl->memseg_arr, name, >>> primary_msl->memseg_arr.len, > >